From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Mauro Carvalho Chehab <maurochehab@gmail.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
nkanchev@mm-sol.com, g.liakhovetski@gmx.de, hverkuil@xs4all.nl,
dacohen@gmail.com, riverful@gmail.com, andrew.b.adams@gmail.com,
shpark7@stanford.edu
Subject: Re: [PATCH 3/3] adp1653: Add driver for LED flash controller
Date: Sun, 22 May 2011 15:39:49 +0300 [thread overview]
Message-ID: <4DD90415.8000908@maxwell.research.nokia.com> (raw)
In-Reply-To: <4DD7A8BC.4020207@gmail.com>
Mauro Carvalho Chehab wrote:
> Em 19-05-2011 07:41, Sakari Ailus escreveu:
>> This patch adds the driver for the adp1653 LED flash controller. This
>> controller supports a high power led in flash and torch modes and an
>> indicator light, sometimes also called privacy light.
>>
>> The adp1653 is used on the Nokia N900.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
>> Signed-off-by: Tuukka Toivonen <tuukkat76@gmail.com>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Signed-off-by: David Cohen <dacohen@gmail.com>
>> ---
>> drivers/media/video/Kconfig | 7 +
>> drivers/media/video/Makefile | 2 +
>> drivers/media/video/adp1653.c | 481 +++++++++++++++++++++++++++++++++++++++++
>> include/media/adp1653.h | 126 +++++++++++
>> 4 files changed, 616 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/media/video/adp1653.c
>> create mode 100644 include/media/adp1653.h
>>
>> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
>> index 00f51dd..c004dbb 100644
>> --- a/drivers/media/video/Kconfig
>> +++ b/drivers/media/video/Kconfig
>> @@ -344,6 +344,13 @@ config VIDEO_TCM825X
>> This is a driver for the Toshiba TCM825x VGA camera sensor.
>> It is used for example in Nokia N800.
>>
>> +config VIDEO_ADP1653
>> + tristate "ADP1653 flash support"
>> + depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER
>> + ---help---
>> + This is a driver for the ADP1653 flash controller. It is used for
>> + example in Nokia N900.
>> +
>> config VIDEO_SAA7110
>> tristate "Philips SAA7110 video decoder"
>> depends on VIDEO_V4L2 && I2C
>
> The patches look sane. I have just one comment: Please, create a separate
> section for the LED controls. OK, some patches already messed the Kconfig stuff
> by mixing sensors together with video decoders, but let's not make the things
> worse.
Hi Mauro,
Thanks for the comment! I'll fix this in the Kconfig for the next patchset.
Regards,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-05-22 12:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 10:41 [PATCH 0/3] V4L2 API for flash devices and the adp1653 flash controller driver Sakari Ailus
2011-05-19 10:41 ` [PATCH 1/3] v4l: Add a class and a set of controls for flash devices Sakari Ailus
2011-05-19 10:41 ` [PATCH 2/3] v4l: Add flash control documentation Sakari Ailus
2011-05-19 10:41 ` [PATCH 3/3] adp1653: Add driver for LED flash controller Sakari Ailus
2011-05-21 11:57 ` Mauro Carvalho Chehab
2011-05-22 12:39 ` Sakari Ailus [this message]
2011-05-19 12:14 ` [PATCH 0/3] V4L2 API for flash devices and the adp1653 flash controller driver Laurent Pinchart
2011-05-19 14:22 ` David Cohen
2011-05-19 14:24 ` Laurent Pinchart
2011-06-30 10:55 ` v4l2 api for flash drivers Andy Shevchenko
2011-06-30 11:06 ` Laurent Pinchart
2011-06-30 11:26 ` Sakari Ailus
2011-07-26 9:12 ` Andy Shevchenko
2011-07-26 9:47 ` Sakari Ailus
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 13:00 [RFC 0/3] V4L2 API for flash devices and the adp1653 flash controller driver Sakari Ailus
2011-05-16 13:00 ` [PATCH 3/3] adp1653: Add driver for LED flash controller Sakari Ailus
2011-05-16 20:31 ` Laurent Pinchart
2011-05-17 5:38 ` Sakari Ailus
2011-05-17 7:23 ` Laurent Pinchart
2011-05-17 10:47 ` Sakari Ailus
2011-05-17 10:51 ` Laurent Pinchart
2011-06-09 15:10 ` Laurent Pinchart
2011-06-10 8:20 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD90415.8000908@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=andrew.b.adams@gmail.com \
--cc=dacohen@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=maurochehab@gmail.com \
--cc=nkanchev@mm-sol.com \
--cc=riverful@gmail.com \
--cc=shpark7@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox