From: Hans de Goede <hdegoede@redhat.com>
To: linux-media@vger.kernel.org
Subject: Re: [git:v4l-utils/master] Add an install target to libv4l2util
Date: Mon, 23 May 2011 16:48:05 +0200 [thread overview]
Message-ID: <4DDA73A5.1080803@redhat.com> (raw)
In-Reply-To: <E1QORwH-0003gY-GA@www.linuxtv.org>
Hi,
On 05/23/2011 12:00 PM, Mauro Carvalho Chehab wrote:
> This is an automatic generated email to let you know that the following patch were queued at the
> http://git.linuxtv.org/v4l-utils.git tree:
>
> Subject: Add an install target to libv4l2util
> Author: Mauro Carvalho Chehab<mchehab@redhat.com>
> Date: Mon May 23 07:00:00 2011 -0300
>
> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
Erm,
This is a static lib, installing static libs globally is considered
bad practice. Either we need to make this a properly versioned .so
and all the API+ABI promises which some with that, or we should just
keep it as a private utility function lib, which gets linked into
a few utils, but not installed system wide.
I think this may have something to do with the new get_media_devices
code, but the commit message is rather undescriptive...
Regards,
Hans
next parent reply other threads:[~2011-05-23 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1QORwH-0003gY-GA@www.linuxtv.org>
2011-05-23 14:48 ` Hans de Goede [this message]
2011-05-23 15:33 ` [git:v4l-utils/master] Add an install target to libv4l2util Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA73A5.1080803@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox