From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28739 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215Ab1EWS3i (ORCPT ); Mon, 23 May 2011 14:29:38 -0400 Message-ID: <4DDAA788.80908@redhat.com> Date: Mon, 23 May 2011 15:29:28 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Guennadi Liakhovetski CC: Hans Petter Selasky , "linux-media@vger.kernel.org" Subject: Re: [PATCH] Inlined functions should be static. References: <201105231607.13668.hselasky@c2i.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: Sender: Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu: > On Mon, 23 May 2011, Hans Petter Selasky wrote: > >> --HPS >> > > (again, inlining would save me copy-pasting) Yeah... hard to comment not-inlined patches... > >> -inline u32 stb0899_do_div(u64 n, u32 d) >> +static inline u32 stb0899_do_div(u64 n, u32 d) > > while at it you could as well remove the unneeded in a C file "inline" > attribute. hmm... foo_do_div()... it seems to be yet-another-implementation of asm/div64.h. If so, it is better to just remove this thing and use the existing function. > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/