* [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
@ 2011-05-23 11:19 Hans Petter Selasky
2011-05-26 0:10 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Hans Petter Selasky @ 2011-05-23 11:19 UTC (permalink / raw)
To: linux-media@vger.kernel.org; +Cc: Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 6 bytes --]
--HPS
[-- Attachment #2: dvb-usb-0001.patch --]
[-- Type: text/x-patch, Size: 1885 bytes --]
From f7a0f7254da47ff88f69314f14043b01ba0764eb Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 12:43:50 +0200
Subject: [PATCH] The USB_SPEED_XXX keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
---
drivers/media/dvb/dvb-usb/gp8psk.h | 6 +++---
drivers/media/dvb/dvb-usb/vp7045.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/gp8psk.h b/drivers/media/dvb/dvb-usb/gp8psk.h
index 831749a..c271b68 100644
--- a/drivers/media/dvb/dvb-usb/gp8psk.h
+++ b/drivers/media/dvb/dvb-usb/gp8psk.h
@@ -78,9 +78,9 @@ extern int dvb_usb_gp8psk_debug;
#define ADV_MOD_DVB_BPSK 9 /* DVB-S BPSK */
#define GET_USB_SPEED 0x07
- #define USB_SPEED_LOW 0
- #define USB_SPEED_FULL 1
- #define USB_SPEED_HIGH 2
+ #define TH_USB_SPEED_LOW 0
+ #define TH_USB_SPEED_FULL 1
+ #define TH_USB_SPEED_HIGH 2
#define RESET_FX2 0x13
diff --git a/drivers/media/dvb/dvb-usb/vp7045.h b/drivers/media/dvb/dvb-usb/vp7045.h
index 969688f..7ce6c00 100644
--- a/drivers/media/dvb/dvb-usb/vp7045.h
+++ b/drivers/media/dvb/dvb-usb/vp7045.h
@@ -36,9 +36,9 @@
#define Tuner_Power_OFF 0
#define GET_USB_SPEED 0x07
- #define USB_SPEED_LOW 0
- #define USB_SPEED_FULL 1
- #define USB_SPEED_HIGH 2
+ #define TH_USB_SPEED_LOW 0
+ #define TH_USB_SPEED_FULL 1
+ #define TH_USB_SPEED_HIGH 2
#define LOCK_TUNER_COMMAND 0x09
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
2011-05-23 11:19 [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors Hans Petter Selasky
@ 2011-05-26 0:10 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2011-05-26 0:10 UTC (permalink / raw)
To: Hans Petter Selasky; +Cc: linux-media@vger.kernel.org
Em 23-05-2011 08:19, Hans Petter Selasky escreveu:
> --HPS
>
>
> dvb-usb-0001.patch
>
>
> From f7a0f7254da47ff88f69314f14043b01ba0764eb Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 12:43:50 +0200
> Subject: [PATCH] The USB_SPEED_XXX keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors.
>
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
> drivers/media/dvb/dvb-usb/gp8psk.h | 6 +++---
> drivers/media/dvb/dvb-usb/vp7045.h | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/gp8psk.h b/drivers/media/dvb/dvb-usb/gp8psk.h
> index 831749a..c271b68 100644
> --- a/drivers/media/dvb/dvb-usb/gp8psk.h
> +++ b/drivers/media/dvb/dvb-usb/gp8psk.h
> @@ -78,9 +78,9 @@ extern int dvb_usb_gp8psk_debug;
> #define ADV_MOD_DVB_BPSK 9 /* DVB-S BPSK */
>
> #define GET_USB_SPEED 0x07
> - #define USB_SPEED_LOW 0
> - #define USB_SPEED_FULL 1
> - #define USB_SPEED_HIGH 2
> + #define TH_USB_SPEED_LOW 0
> + #define TH_USB_SPEED_FULL 1
> + #define TH_USB_SPEED_HIGH 2
>
> #define RESET_FX2 0x13
>
> diff --git a/drivers/media/dvb/dvb-usb/vp7045.h b/drivers/media/dvb/dvb-usb/vp7045.h
> index 969688f..7ce6c00 100644
> --- a/drivers/media/dvb/dvb-usb/vp7045.h
> +++ b/drivers/media/dvb/dvb-usb/vp7045.h
> @@ -36,9 +36,9 @@
> #define Tuner_Power_OFF 0
>
> #define GET_USB_SPEED 0x07
> - #define USB_SPEED_LOW 0
> - #define USB_SPEED_FULL 1
> - #define USB_SPEED_HIGH 2
> + #define TH_USB_SPEED_LOW 0
> + #define TH_USB_SPEED_FULL 1
> + #define TH_USB_SPEED_HIGH 2
>
> #define LOCK_TUNER_COMMAND 0x09
Nah. Those vars are unused on those drivers. Just remove them.
Thanks!
Mauro.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-26 0:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 11:19 [PATCH] The USB_SPEED... keywords are already defined by the USB stack. Rename currently unused macros to avoid possible future warnings and errors Hans Petter Selasky
2011-05-26 0:10 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox