public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Petter Selasky <hselasky@c2i.net>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Define parameter description after the parameter itself.
Date: Wed, 25 May 2011 21:13:40 -0300	[thread overview]
Message-ID: <4DDD9B34.9080103@redhat.com> (raw)
In-Reply-To: <201105231327.11791.hselasky@c2i.net>

Em 23-05-2011 08:27, Hans Petter Selasky escreveu:
> --HPS
> 
> 
> dvb-usb-0008.patch
> 
> 
> From 2f5378e5c5cc5528473f77321879fb075005d3dd Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 13:26:04 +0200
> Subject: [PATCH] Define parameter description after the parameter itself.
> 
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
>  drivers/media/video/tda7432.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
> index 3941f95..398b9fb 100644
> --- a/drivers/media/video/tda7432.c
> +++ b/drivers/media/video/tda7432.c
> @@ -50,8 +50,8 @@ static int loudness; /* disable loudness by default */
>  static int debug;	 /* insmod parameter */
>  module_param(debug, int, S_IRUGO | S_IWUSR);
>  module_param(loudness, int, S_IRUGO);
> -MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
>  module_param(maxvol, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");

Ok, but this doesn't change the fact that debug and loudness aren't commented.
Could you please also add descriptions for those parameters where no descriptions
were provided? 

Thanks!
Mauro.

      reply	other threads:[~2011-05-26  0:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 11:27 [PATCH] Define parameter description after the parameter itself Hans Petter Selasky
2011-05-26  0:13 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDD9B34.9080103@redhat.com \
    --to=mchehab@redhat.com \
    --cc=hselasky@c2i.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox