* [PATCH] Define parameter description after the parameter itself.
@ 2011-05-23 11:27 Hans Petter Selasky
2011-05-26 0:13 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Hans Petter Selasky @ 2011-05-23 11:27 UTC (permalink / raw)
To: linux-media@vger.kernel.org; +Cc: Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 6 bytes --]
--HPS
[-- Attachment #2: dvb-usb-0008.patch --]
[-- Type: text/x-patch, Size: 1012 bytes --]
From 2f5378e5c5cc5528473f77321879fb075005d3dd Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 13:26:04 +0200
Subject: [PATCH] Define parameter description after the parameter itself.
Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
---
drivers/media/video/tda7432.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
index 3941f95..398b9fb 100644
--- a/drivers/media/video/tda7432.c
+++ b/drivers/media/video/tda7432.c
@@ -50,8 +50,8 @@ static int loudness; /* disable loudness by default */
static int debug; /* insmod parameter */
module_param(debug, int, S_IRUGO | S_IWUSR);
module_param(loudness, int, S_IRUGO);
-MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
module_param(maxvol, int, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Define parameter description after the parameter itself.
2011-05-23 11:27 [PATCH] Define parameter description after the parameter itself Hans Petter Selasky
@ 2011-05-26 0:13 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2011-05-26 0:13 UTC (permalink / raw)
To: Hans Petter Selasky; +Cc: linux-media@vger.kernel.org
Em 23-05-2011 08:27, Hans Petter Selasky escreveu:
> --HPS
>
>
> dvb-usb-0008.patch
>
>
> From 2f5378e5c5cc5528473f77321879fb075005d3dd Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 13:26:04 +0200
> Subject: [PATCH] Define parameter description after the parameter itself.
>
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
> ---
> drivers/media/video/tda7432.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/tda7432.c b/drivers/media/video/tda7432.c
> index 3941f95..398b9fb 100644
> --- a/drivers/media/video/tda7432.c
> +++ b/drivers/media/video/tda7432.c
> @@ -50,8 +50,8 @@ static int loudness; /* disable loudness by default */
> static int debug; /* insmod parameter */
> module_param(debug, int, S_IRUGO | S_IWUSR);
> module_param(loudness, int, S_IRUGO);
> -MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
> module_param(maxvol, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(maxvol,"Set maximium volume to +20db (0), default is 0db(1)");
Ok, but this doesn't change the fact that debug and loudness aren't commented.
Could you please also add descriptions for those parameters where no descriptions
were provided?
Thanks!
Mauro.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-26 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 11:27 [PATCH] Define parameter description after the parameter itself Hans Petter Selasky
2011-05-26 0:13 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox