Re: XC4000: setting registers

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Hi Istvan,

Em 04-06-2011 12:12, istvan_v@mailbox.hu escreveu:
> This patch implements setting the registers in xc4000_set_params()
> and xc4000_set_analog_params(). A new register is defined which enables
> filtering of the composite video output (this is needed to avoid bad
> picture quality with some boards).
> 
> Signed-off-by: Istvan Varga <istvan_v@mailbox.hu>
> 

This one breaks compilation:

drivers/media/common/tuners/xc4000.c: In function ‘xc4000_set_analog_params’:
drivers/media/common/tuners/xc4000.c:1340: error: ‘type’ undeclared (first use in this function)
drivers/media/common/tuners/xc4000.c:1340: error: (Each undeclared identifier is reported only once
drivers/media/common/tuners/xc4000.c:1340: error: for each function it appears in.)
make[3]: ** [drivers/media/common/tuners/xc4000.o] Erro 1
make[2]: ** [drivers/media/common/tuners] Erro 2
make[1]: ** [drivers/media/common] Erro 2
make: ** [drivers/media/] Erro 2

We should not allow that a patch in the middle of a series to break the compilation,
as this breaks git bisect command. I fixed it with a hack.

All patches you've sent were added at my experimental tree, including the one that
added a card type inside the struct.

I had to rebase the tree with:

git filter-branch -f --env-filter '{ GIT_AUTHOR_NAME="Istvan Varga"; GIT_AUTHOR_EMAIL="istvan_v@mailbox.hu"; export GIT_AUTHOR_NAME;}' ^3be84e2e789af734a35ad0559c2d7c4931d0fe91^ HEAD 

As your emails are being sent without your name on it (from is: istvan_v@mailbox.hu <istvan_v@mailbox.hu>).

I didn't made any review of them. Please let me know when you finish submitting
the patches for me to do a review at the resulting code.

Ah, I'd appreciate if you could fix your emails. It takes me some time to
reformat the patches, as you're sending the patches as attachments, but my
email scripts aren't ready for patches with multiple mime types. Patchwork
might help, but it also got only 4 patches from you (not sure if this is due
to patchwork bugs or due to the attachments). It also helps if you could add
[PATCH] at the email subject. I'm setting a backup process due to the constant
patchwork failures, but my alternative logic relies on having [PATCH] at the
subject logic, to move the patches into a separate mail directory.

thanks,
Mauro.