From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ffm.saftware.de ([83.141.3.46]:38968 "EHLO ffm.saftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757515Ab1FINH6 (ORCPT ); Thu, 9 Jun 2011 09:07:58 -0400 Message-ID: <4DF0C5AB.5040304@linuxtv.org> Date: Thu, 09 Jun 2011 15:07:55 +0200 From: Andreas Oberritter MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Linux Media Mailing List Subject: Re: [PATCH 05/13] [media] dvb/audio.h: Remove definition for AUDIO_GET_PTS References: <20110608172302.3e2294af@pedra> <4DF0C015.1090807@linuxtv.org> <4DF0C4E1.1020406@redhat.com> In-Reply-To: <4DF0C4E1.1020406@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: Sender: On 06/09/2011 03:04 PM, Mauro Carvalho Chehab wrote: > Hi Andreas, > > Em 09-06-2011 09:44, Andreas Oberritter escreveu: >> On 06/08/2011 10:23 PM, Mauro Carvalho Chehab wrote: >>> While this ioctl is defined inside dvb/audio.h, it is not docummented >>> at the API specs, nor implemented on any driver inside the Linux Kernel. >>> So, it doesn't make sense to keep it here. >>> >>> As this is not used anywere, removing it is not a regression. So, >>> there's no need to use the normal features-to-be-removed process. >>> >>> Signed-off-by: Mauro Carvalho Chehab >>> >>> diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h >>> index d47bccd..c1b3555 100644 >>> --- a/include/linux/dvb/audio.h >>> +++ b/include/linux/dvb/audio.h >>> @@ -118,18 +118,6 @@ typedef __u16 audio_attributes_t; >>> #define AUDIO_SET_ATTRIBUTES _IOW('o', 17, audio_attributes_t) >>> #define AUDIO_SET_KARAOKE _IOW('o', 18, audio_karaoke_t) >>> >>> -/** >>> - * AUDIO_GET_PTS >>> - * >>> - * Read the 33 bit presentation time stamp as defined >>> - * in ITU T-REC-H.222.0 / ISO/IEC 13818-1. >>> - * >>> - * The PTS should belong to the currently played >>> - * frame if possible, but may also be a value close to it >>> - * like the PTS of the last decoded frame or the last PTS >>> - * extracted by the PES parser. >>> - */ >>> -#define AUDIO_GET_PTS _IOR('o', 19, __u64) >>> #define AUDIO_BILINGUAL_CHANNEL_SELECT _IO('o', 20) >>> >>> #endif /* _DVBAUDIO_H_ */ >> >> Please don't apply this patch. In general, many ioctls aren't >> implemented in mainline drivers, because most if not all supported >> devices inside the kernel tree are either PCI or USB add-in devices and >> usually quite simple compared to a STB. >> >> This ioctl is used at least by enigma2 in userspace and implemented in >> drivers for several generations of the dreambox. > > If this is implemented on userspace only, what's the point of having it > inside the kernel API? ... implemented in *kernel* drivers for several generations of the dreambox. I mentioned enigma2, because a kernel API without a user wouldn't make much sense either. Regards, Andreas