From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, nkanchev@mm-sol.com,
g.liakhovetski@gmx.de, hverkuil@xs4all.nl, dacohen@gmail.com,
riverful@gmail.com, andrew.b.adams@gmail.com,
shpark7@stanford.edu
Subject: Re: [PATCH 3/3] adp1653: Add driver for LED flash controller
Date: Fri, 10 Jun 2011 11:20:12 +0300 [thread overview]
Message-ID: <4DF1D3BC.8080303@maxwell.research.nokia.com> (raw)
In-Reply-To: <201106091710.18273.laurent.pinchart@ideasonboard.com>
Laurent Pinchart wrote:
> Hi Sakari,
>
> On Monday 16 May 2011 15:00:39 Sakari Ailus wrote:
>> This patch adds the driver for the adp1653 LED flash controller. This
>> controller supports a high power led in flash and torch modes and an
>> indicator light, sometimes also called privacy light.
>>
>> The adp1653 is used on the Nokia N900.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
>> Signed-off-by: Tuukka Toivonen <tuukkat76@gmail.com>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Signed-off-by: David Cohen <dacohen@gmail.com>
>
> [snip]
>
>> + v4l2_ctrl_new_std(&flash->ctrls, &adp1653_ctrl_ops,
>> + V4L2_CID_FLASH_FAULT, 0, V4L2_FLASH_FAULT_OVER_VOLTAGE
>> + | V4L2_FLASH_FAULT_OVER_TEMPERATURE
>> + | V4L2_FLASH_FAULT_SHORT_CIRCUIT, 0, 0);
>
> You need to mark the fault control as volatile.
Thanks for catching this!
I'll fix it for the pull req.
Cheers,
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2011-06-10 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 13:00 [RFC 0/3] V4L2 API for flash devices and the adp1653 flash controller driver Sakari Ailus
2011-05-16 13:00 ` [PATCH 1/3] v4l: Add a class and a set of controls for flash devices Sakari Ailus
2011-05-16 13:00 ` [PATCH 2/3] v4l: Add flash control documentation Sakari Ailus
2011-05-16 13:00 ` [PATCH 3/3] adp1653: Add driver for LED flash controller Sakari Ailus
2011-05-16 20:31 ` Laurent Pinchart
2011-05-17 5:38 ` Sakari Ailus
2011-05-17 7:23 ` Laurent Pinchart
2011-05-17 10:47 ` Sakari Ailus
2011-05-17 10:51 ` Laurent Pinchart
2011-06-09 15:10 ` Laurent Pinchart
2011-06-10 8:20 ` Sakari Ailus [this message]
2011-05-16 16:48 ` [RFC 0/3] V4L2 API for flash devices and the adp1653 flash controller driver Sakari Ailus
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 10:41 [PATCH " Sakari Ailus
2011-05-19 10:41 ` [PATCH 3/3] adp1653: Add driver for LED flash controller Sakari Ailus
2011-05-21 11:57 ` Mauro Carvalho Chehab
2011-05-22 12:39 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF1D3BC.8080303@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=andrew.b.adams@gmail.com \
--cc=dacohen@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=nkanchev@mm-sol.com \
--cc=riverful@gmail.com \
--cc=shpark7@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox