From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([147.243.128.26]:40559 "EHLO mgw-da02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754992Ab1FJIUX (ORCPT ); Fri, 10 Jun 2011 04:20:23 -0400 Message-ID: <4DF1D3BC.8080303@maxwell.research.nokia.com> Date: Fri, 10 Jun 2011 11:20:12 +0300 From: Sakari Ailus MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org, nkanchev@mm-sol.com, g.liakhovetski@gmx.de, hverkuil@xs4all.nl, dacohen@gmail.com, riverful@gmail.com, andrew.b.adams@gmail.com, shpark7@stanford.edu Subject: Re: [PATCH 3/3] adp1653: Add driver for LED flash controller References: <4DD11FEC.8050308@maxwell.research.nokia.com> <1305550839-16724-3-git-send-email-sakari.ailus@maxwell.research.nokia.com> <201106091710.18273.laurent.pinchart@ideasonboard.com> In-Reply-To: <201106091710.18273.laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-ID: Sender: Laurent Pinchart wrote: > Hi Sakari, > > On Monday 16 May 2011 15:00:39 Sakari Ailus wrote: >> This patch adds the driver for the adp1653 LED flash controller. This >> controller supports a high power led in flash and torch modes and an >> indicator light, sometimes also called privacy light. >> >> The adp1653 is used on the Nokia N900. >> >> Signed-off-by: Sakari Ailus >> Signed-off-by: Tuukka Toivonen >> Signed-off-by: Laurent Pinchart >> Signed-off-by: David Cohen > > [snip] > >> + v4l2_ctrl_new_std(&flash->ctrls, &adp1653_ctrl_ops, >> + V4L2_CID_FLASH_FAULT, 0, V4L2_FLASH_FAULT_OVER_VOLTAGE >> + | V4L2_FLASH_FAULT_OVER_TEMPERATURE >> + | V4L2_FLASH_FAULT_SHORT_CIRCUIT, 0, 0); > > You need to mark the fault control as volatile. Thanks for catching this! I'll fix it for the pull req. Cheers, -- Sakari Ailus sakari.ailus@maxwell.research.nokia.com