Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Jan Hoogenraad]

Hans, Mauro:

I have tried to compile the sources at git://linuxtv.org/media_build.git,
using build.sh

At
cx18-driver.h:659:
     struct workqueue_struct *out_work_queue;
     char out_workq_name[12]; /* "cx18-NN-out" */

     struct workqueue_struct *out_work_queue;
     char out_workq_name[12]; /* "cx18-NN-out" */


cx18-driver.c:718
a similar problem occurs: the following code block is repeated:

static int __devinit cx18_create_out_workq(struct cx18 *cx)
{
     snprintf(cx->out_workq_name, sizeof(cx->out_workq_name), "%s-out",
          cx->v4l2_dev.name);
     cx->out_work_queue = create_workqueue(cx->out_workq_name);
     if (cx->out_work_queue == NULL) {
         CX18_ERR("Unable to create outgoing mailbox handler threads\n");
         return -ENOMEM;
     }
     return 0;
}

static int __devinit cx18_create_out_workq(struct cx18 *cx)
{
     snprintf(cx->out_workq_name, sizeof(cx->out_workq_name), "%s-out",
          cx->v4l2_dev.name);
     cx->out_work_queue = create_workqueue(cx->out_workq_name);
     if (cx->out_work_queue == NULL) {
         CX18_ERR("Unable to create outgoing mailbox handler threads\n");
         return -ENOMEM;
     }
     return 0;
}

Furthermore, there is an error that is present in three sources:
At
./v4l/dvbdev.c:466: twice:
the escape sequence \\" sould be replaced with \"

./rc-main.c:1131: twice:
the escape sequence \\" sould be replaced with \"

./v4l/v4l2-dev.c:782: twice:
the escape sequence \\" sould be replaced with \"


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Andy Walls]

Jan Hoogenraad <jan-conceptronic@hoogenraad.net> wrote:

>Hans, Mauro:
>
>I have tried to compile the sources at
>git://linuxtv.org/media_build.git,
>using build.sh
>
>At
>cx18-driver.h:659:
>     struct workqueue_struct *out_work_queue;
>     char out_workq_name[12]; /* "cx18-NN-out" */
>
>     struct workqueue_struct *out_work_queue;
>     char out_workq_name[12]; /* "cx18-NN-out" */
>
>
>cx18-driver.c:718
>a similar problem occurs: the following code block is repeated:
>
>static int __devinit cx18_create_out_workq(struct cx18 *cx)
>{
>     snprintf(cx->out_workq_name, sizeof(cx->out_workq_name), "%s-out",
>          cx->v4l2_dev.name);
>     cx->out_work_queue = create_workqueue(cx->out_workq_name);
>     if (cx->out_work_queue == NULL) {
>       CX18_ERR("Unable to create outgoing mailbox handler threads\n");
>         return -ENOMEM;
>     }
>     return 0;
>}
>
>static int __devinit cx18_create_out_workq(struct cx18 *cx)
>{
>     snprintf(cx->out_workq_name, sizeof(cx->out_workq_name), "%s-out",
>          cx->v4l2_dev.name);
>     cx->out_work_queue = create_workqueue(cx->out_workq_name);
>     if (cx->out_work_queue == NULL) {
>       CX18_ERR("Unable to create outgoing mailbox handler threads\n");
>         return -ENOMEM;
>     }
>     return 0;
>}
>
>Furthermore, there is an error that is present in three sources:
>At
>./v4l/dvbdev.c:466: twice:
>the escape sequence \\" sould be replaced with \"
>
>./rc-main.c:1131: twice:
>the escape sequence \\" sould be replaced with \"
>
>./v4l/v4l2-dev.c:782: twice:
>the escape sequence \\" sould be replaced with \"
>
>
>-- 
>Jan Hoogenraad
>Hoogenraad Interface Services
>Postbus 2717
>3500 GS Utrecht
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media"
>in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

What are the error messages?

Tejun Heo made quite a number of workqueue changes, and the cx18 driver got dragged forward with them.  So did ivtv for that matter.

Just disable the cx18 driver if you don't need it for an older kernel.

Regards,
Andy

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Devin Heitmueller]

On Fri, Jun 10, 2011 at 8:34 AM, Andy Walls <awalls@md.metrocast.net> wrote:
> What are the error messages?
>
> Tejun Heo made quite a number of workqueue changes, and the cx18 driver got dragged forward with them.  So did ivtv for that matter.
>
> Just disable the cx18 driver if you don't need it for an older kernel.
>
> Regards,
> Andy

Another highly relevant piece of information to know is what kernel
Jan is running on.  It is probably from before the workqueue changes.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Jan Hoogenraad]

Andy:

Something along the line of id already defined.
I just corrected the code by removing the duplicate lines that are in 
the sources of the tar.

The other 3 files have a bad escape sequence in a line saying that this 
is the backports. One backslash not removed in a script, I guess.

Devin:

The version does not matter for the cx18 problem: any compiler complains 
on duplicate lines.

Anyway: 2.6.32-32-generic-pae #62-Ubuntu SMP Wed Apr 20 22:10:33 UTC 
2011 i686 GNU/Linux

Devin Heitmueller wrote:
> On Fri, Jun 10, 2011 at 8:34 AM, Andy Walls<awalls@md.metrocast.net>  wrote:
>> What are the error messages?
>>
>> Tejun Heo made quite a number of workqueue changes, and the cx18 driver got dragged forward with them.  So did ivtv for that matter.
>>
>> Just disable the cx18 driver if you don't need it for an older kernel.
>>
>> Regards,
>> Andy
>
> Another highly relevant piece of information to know is what kernel
> Jan is running on.  It is probably from before the workqueue changes.
>
> Devin
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Jan Hoogenraad]

[-- Attachment #1: Type: text/plain, Size: 3443 bytes --]

Sorry; too fast a reaction; I did not realize that the build script 
creates a version per kernel, and that my messages thus become hard to 
trace.

The cx18 doubles were clear. The one in the code file may be caused by
v2.6.37_dont_use_alloc_ordered_workqueue.patch
but I don't see the problem in the header file in that patch.



Below the 3 non cx18 offending lines:

line in v4l2-dev.c:

	printk(KERN_ERR "WARNING: You are using an experimental version of the 
media stack.\n\tAs the driver is backported to an older kernel, it 
doesn't offer\n\tenough quality for its usage in production.\n\tUse it 
with care.\nLatest git patches (needed if you report a bug to 
linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] 
DocBook: Don't be noisy at make 
cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert 
\\"[media] dvb/audio.h: Remove definition for 
AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] 
DocBook/video.xml: Document the remaining data structures\n");


line in rc-main.c:

	printk(KERN_ERR "WARNING: You are using an experimental version of the 
media stack.\n\tAs the driver is backported to an older kernel, it 
doesn't offer\n\tenough quality for its usage in production.\n\tUse it 
with care.\nLatest git patches (needed if you report a bug to 
linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] 
DocBook: Don't be noisy at make 
cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert 
\\"[media] dvb/audio.h: Remove definition for 
AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] 
DocBook/video.xml: Document the remaining data structures\n");



line in dvbdeb.c:


	printk(KERN_ERR "WARNING: You are using an experimental version of the 
media stack.\n\tAs the driver is backported to an older kernel, it 
doesn't offer\n\tenough quality for its usage in production.\n\tUse it 
with care.\nLatest git patches (needed if you report a bug to 
linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] 
DocBook: Don't be noisy at make 
cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert 
\\"[media] dvb/audio.h: Remove definition for 
AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] 
DocBook/video.xml: Document the remaining data structures\n");

Jan Hoogenraad wrote:
> Andy:
>
> Something along the line of id already defined.
> I just corrected the code by removing the duplicate lines that are in
> the sources of the tar.
>
> The other 3 files have a bad escape sequence in a line saying that this
> is the backports. One backslash not removed in a script, I guess.
>
> Devin:
>
> The version does not matter for the cx18 problem: any compiler complains
> on duplicate lines.
>
> Anyway: 2.6.32-32-generic-pae #62-Ubuntu SMP Wed Apr 20 22:10:33 UTC
> 2011 i686 GNU/Linux
>
> Devin Heitmueller wrote:
>> On Fri, Jun 10, 2011 at 8:34 AM, Andy Walls<awalls@md.metrocast.net>
>> wrote:
>>> What are the error messages?
>>>
>>> Tejun Heo made quite a number of workqueue changes, and the cx18
>>> driver got dragged forward with them. So did ivtv for that matter.
>>>
>>> Just disable the cx18 driver if you don't need it for an older kernel.
>>>
>>> Regards,
>>> Andy
>>
>> Another highly relevant piece of information to know is what kernel
>> Jan is running on. It is probably from before the workqueue changes.
>>
>> Devin
>>
>
>


[-- Attachment #2: jan-verisign.vcf --]
[-- Type: text/x-vcard, Size: 322 bytes --]

begin:vcard
fn:Jan Hoogenraad
n:Hoogenraad;Jan
org:Hoogenraad Interface Services
adr;quoted-printable;dom:;;Postbus 2717;Utrecht;;-- =
	=0D=0A=
	Jan Hoogenraad=0D=0A=
	Hoogenraad Interface Services=0D=0A=
	Postbus 2717=0D=0A=
	3500 GS
email;internet:jan-verisign@hoogenraad.net
x-mozilla-html:FALSE
version:2.1
end:vcard

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Mauro Carvalho Chehab]

Em 10-06-2011 11:14, Jan Hoogenraad escreveu:
> Sorry; too fast a reaction; I did not realize that the build script creates a version per kernel, and that my messages thus become hard to trace.
> 
> The cx18 doubles were clear. The one in the code file may be caused by
> v2.6.37_dont_use_alloc_ordered_workqueue.patch
> but I don't see the problem in the header file in that patch.
> 
> 
> 
> Below the 3 non cx18 offending lines:
> 
> line in v4l2-dev.c:
> 
>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");
> 
> 
> line in rc-main.c:
> 
>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");
> 
> 
> 
> line in dvbdeb.c:
> 
> 
>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");

It seems to be caused by a bad escape sequence for the latest patch.
I'll fix the Makefile script.

Thanks for reporting it.

Re: Media_build does not compile due to errors in cx18-driver.h, cx18-driver.c and dvbdev.c /rc-main.c

[Mauro Carvalho Chehab]

Em 10-06-2011 12:34, Mauro Carvalho Chehab escreveu:
> Em 10-06-2011 11:14, Jan Hoogenraad escreveu:
>> Sorry; too fast a reaction; I did not realize that the build script creates a version per kernel, and that my messages thus become hard to trace.
>>
>> The cx18 doubles were clear. The one in the code file may be caused by
>> v2.6.37_dont_use_alloc_ordered_workqueue.patch
>> but I don't see the problem in the header file in that patch.
>>
>>
>>
>> Below the 3 non cx18 offending lines:
>>
>> line in v4l2-dev.c:
>>
>>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");
>>
>>
>> line in rc-main.c:
>>
>>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");
>>
>>
>>
>> line in dvbdeb.c:
>>
>>
>>     printk(KERN_ERR "WARNING: You are using an experimental version of the media stack.\n\tAs the driver is backported to an older kernel, it doesn't offer\n\tenough quality for its usage in production.\n\tUse it with care.\nLatest git patches (needed if you report a bug to linux-media@vger.kernel.org):\n\t75125b9d44456e0cf2d1fbb72ae33c13415299d1 [media] DocBook: Don't be noisy at make cleanmediadocs\n\t0fba2f7ff0c4d9f48a5c334826a22db32f816a76 Revert \\"[media] dvb/audio.h: Remove definition for AUDIO_GET_PTS\\"\n\t4f75ad768da3c5952d1e7080045a5b5ce7b0d85d [media] DocBook/video.xml: Document the remaining data structures\n");
> 
> It seems to be caused by a bad escape sequence for the latest patch.
> I'll fix the Makefile script.
> 
> Thanks for reporting it.

Fixed. It is building fine right now, against RHEL 6.1 kernel (2.6.32-131).

Thanks,
Mauro.