From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Mike Isely <isely@isely.net>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv4 PATCH 5/8] tuner-core: fix tuner_resume: use t->mode instead of t->type.
Date: Sun, 12 Jun 2011 11:42:08 -0300 [thread overview]
Message-ID: <4DF4D040.3020706@redhat.com> (raw)
In-Reply-To: <ce2a9bf37e65aba48a2835bfcb4b84abe497bcb7.1307875512.git.hans.verkuil@cisco.com>
Em 12-06-2011 07:59, Hans Verkuil escreveu:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> set_mode is called with t->type, which is the tuner type. Instead, use
> t->mode which is the actual tuner mode (i.e. radio vs tv).
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Not tested, but it seems ok.
> ---
> drivers/media/video/tuner-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
> index bf7fc33..ffe5de3 100644
> --- a/drivers/media/video/tuner-core.c
> +++ b/drivers/media/video/tuner-core.c
> @@ -1201,7 +1201,7 @@ static int tuner_resume(struct i2c_client *c)
> tuner_dbg("resume\n");
>
> if (!t->standby)
> - if (set_mode(t, t->type))
> + if (set_mode(t, t->mode))
> set_freq(t, 0);
> return 0;
> }
next prev parent reply other threads:[~2011-06-12 14:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 10:59 tuner-core: fix g_freq/s_std and g/s_tuner Hans Verkuil
2011-06-12 10:59 ` [RFCv4 PATCH 1/8] tuner-core: rename check_mode to supported_mode Hans Verkuil
2011-06-12 10:59 ` [RFCv4 PATCH 2/8] tuner-core: change return type of set_mode_freq to bool Hans Verkuil
2011-06-12 14:39 ` Mauro Carvalho Chehab
2011-06-12 10:59 ` [RFCv4 PATCH 3/8] tuner-core: simplify the standard fixup Hans Verkuil
2011-06-12 14:39 ` Mauro Carvalho Chehab
2011-06-12 10:59 ` [RFCv4 PATCH 4/8] tuner-core: fix s_std and s_tuner Hans Verkuil
2011-06-12 14:41 ` Mauro Carvalho Chehab
2011-06-12 10:59 ` [RFCv4 PATCH 5/8] tuner-core: fix tuner_resume: use t->mode instead of t->type Hans Verkuil
2011-06-12 14:42 ` Mauro Carvalho Chehab [this message]
2011-06-12 10:59 ` [RFCv4 PATCH 6/8] v4l2-ioctl.c: prefill tuner type for g_frequency and g/s_tuner Hans Verkuil
2011-06-12 12:41 ` Andy Walls
2011-06-12 14:36 ` Mauro Carvalho Chehab
2011-06-12 15:46 ` Hans Verkuil
2011-06-12 17:08 ` Mauro Carvalho Chehab
2011-06-12 19:41 ` Hans Verkuil
2011-06-12 21:52 ` Mauro Carvalho Chehab
2011-06-12 10:59 ` [RFCv4 PATCH 7/8] pvrusb2: fix g/s_tuner support Hans Verkuil
2011-06-12 14:43 ` Mauro Carvalho Chehab
2011-06-12 10:59 ` [RFCv4 PATCH 8/8] bttv: fix s_tuner for radio Hans Verkuil
2011-06-12 14:43 ` Mauro Carvalho Chehab
2011-06-12 14:37 ` [RFCv4 PATCH 1/8] tuner-core: rename check_mode to supported_mode Mauro Carvalho Chehab
2011-06-12 16:07 ` Hans Verkuil
2011-06-12 17:27 ` Mauro Carvalho Chehab
2011-06-12 17:32 ` Mauro Carvalho Chehab
2011-06-12 18:09 ` Hans Verkuil
2011-06-12 22:06 ` Mauro Carvalho Chehab
2011-06-13 10:23 ` Hans Verkuil
2011-06-13 11:45 ` Mauro Carvalho Chehab
2011-06-13 12:07 ` Hans Verkuil
2011-06-13 12:32 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF4D040.3020706@redhat.com \
--to=mchehab@redhat.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=isely@isely.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox