public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Some fixes for alsa_stream
Date: Mon, 13 Jun 2011 23:01:48 -0300	[thread overview]
Message-ID: <4DF6C10C.8070605@redhat.com> (raw)

Hi Devin,

I've made a few fixes for your alsa_stream.c, used on tvtime.
They are at:
	http://git.linuxtv.org/xawtv3.git


In particular, those are the more interesting ones:

commit a1bb5ade5c2b09d6d6d624d18025f9e2c4398495
    alsa_stream: negotiate the frame rate

Without this patch, one of my em28xx devices doesn't work. It uses
32 k rate, while the playback minimal rate is 44.1 k.
I've changed the entire frame rate logic, to be more reliable, and to
avoid needing to do frame rate conversion, if both capture and playback
devices support the same rate.

commit 8adb3d7442b22022b9ca897b0b914962adf41270
    alsa_stream: Reduce CPU usage by putting the thread into blocking mode

This is just an optimization. I can't see why are you using a non-block
mode, as it works fine blocking.

commit c67f7aeb86c1caceb7ab30439d169356ea5b1e72
    alsa_stream.c: use mmap mode instead of the normal mode

Instead of using the normal way, this patch implements mmap mode, and change
it to be the default mode. This should also help to reduce CPU usage.

Feel free to rebase those patches and apply into your tvtime tree, if you
want.

Cheers,
Mauro.

             reply	other threads:[~2011-06-14  2:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  2:01 Mauro Carvalho Chehab [this message]
2011-06-14 12:48 ` Some fixes for alsa_stream Hans de Goede
2011-06-14 13:05   ` Mauro Carvalho Chehab
2011-06-14 13:39     ` Mauro Carvalho Chehab
2011-06-14 13:47     ` Hans de Goede
2011-06-14 13:52       ` Devin Heitmueller
2011-06-14 14:17         ` Mauro Carvalho Chehab
2011-06-14 14:37           ` Hans de Goede
2011-06-14 14:45             ` Mauro Carvalho Chehab
2011-06-14 14:48               ` Devin Heitmueller
2011-06-14 15:51                 ` Mauro Carvalho Chehab
2011-06-15 13:43               ` Hans de Goede
2011-06-15 14:25                 ` Mauro Carvalho Chehab
2011-06-15 14:35                   ` Hans de Goede
2011-06-15 14:51                     ` Mauro Carvalho Chehab
2011-06-15 15:45                     ` Mauro Carvalho Chehab
2011-06-16 12:29                       ` Hans de Goede
2011-06-16 14:38                         ` Mauro Carvalho Chehab
2011-06-16 15:11                           ` Hans de Goede
2011-06-16 15:35                             ` Mauro Carvalho Chehab
2011-06-16 18:19                               ` Hans de Goede
2011-06-16 18:28                                 ` Mauro Carvalho Chehab
2011-06-15 14:36                   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF6C10C.8070605@redhat.com \
    --to=mchehab@redhat.com \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox