From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Marek <mmarek@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [media] DocBook: Use base64 for gif/png files
Date: Thu, 16 Jun 2011 11:34:08 -0300 [thread overview]
Message-ID: <4DFA1460.2090507@redhat.com> (raw)
In-Reply-To: <20110616142545.GA5785@infradead.org>
Em 16-06-2011 11:25, Christoph Hellwig escreveu:
> On Thu, Jun 16, 2011 at 11:15:19AM -0300, Mauro Carvalho Chehab wrote:
>> The patch utility doesn't work with non-binary files. This causes some
>> tools to break, like generating tarball targets and the scripts that
>> generate diff patches at http://www.kernel.org/pub/linux/kernel/v2.6/.
>>
>> So, let's convert all binaries to ascii using base64, and add a
>> logic at Makefile to convert them back into binaries at runtime.
>
> Given that all the gifs are not just relatively trivial, but also things
> that looks like they originated or at least should as vector graphics
> I'd recommend to replace them by SVG files. These also have the benefit
> of actually beeing practically patchable.
This is a good idea, but it would require to re-draw everything, as we don't
have those files vectorized (I might have one or two svg files on an older
tree, as I had to re-generate some graphics that used to be just pdf).
One of the reasons why SVG was not used in the past is that there used to have a
target to generate pdf files, and I think that the DocBook tools available on
that time weren't capable of working with svg. Not sure if xmlto currently
supports it, but, as we've removed the pdf generation for the media API,
changing them to svg is ok.
Mauro.
prev parent reply other threads:[~2011-06-16 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 14:15 [PATCH] [media] DocBook: Use base64 for gif/png files Mauro Carvalho Chehab
2011-06-16 14:25 ` Christoph Hellwig
2011-06-16 14:34 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA1460.2090507@redhat.com \
--to=mchehab@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox