DVB_NET help message is useless

DVB_NET help message is useless

[Jiri Slaby]

Hi,

I've just updated to 3.0-rc and saw CONFIG_DVB_NET. Hmm, let's see
what's that by asking with '?'. And I got this crap:
================
CONFIG_DVB_NET:

The DVB network support in the DVB core can
optionally be disabled if this
option is set to N.

If unsure say Y.
================
Why do you think this help message is useful? It's clear to
everybody that if one eventually disables it it will be disabled. The
help message should mention _what_ the network support is.

I would send a patch, but I really have no idea what's that good for.

thanks,
-- 
js

Re: DVB_NET help message is useless

[Hans Petter Selasky]

On Thursday 16 June 2011 09:06:59 Jiri Slaby wrote:
> I would send a patch, but I really have no idea what's that good for.

DVB network support is referring to the IP stack. This option is set to "N" 
when compiling the Linux DVB stack on systems without IP networking.

Please submit a patch if you need a better description.

--HPS

Re: DVB_NET help message is useless

[Mauro Carvalho Chehab]

Em 16-06-2011 04:06, Jiri Slaby escreveu:
> Hi,
> 
> I've just updated to 3.0-rc and saw CONFIG_DVB_NET. Hmm, let's see
> what's that by asking with '?'. And I got this crap:
> ================
> CONFIG_DVB_NET:
> 
> The DVB network support in the DVB core can
> optionally be disabled if this
> option is set to N.
> 
> If unsure say Y.
> ================
> Why do you think this help message is useful? It's clear to
> everybody that if one eventually disables it it will be disabled. The
> help message should mention _what_ the network support is.
> 
> I would send a patch, but I really have no idea what's that good for.

As Hans answered this option disables the IP stack from the DVB driver. The
IP stack is part of the DVB standard. It is used, for example, by automatic 
firmware updates used on STB's. It can also be used to access the Internet,
via the DVB card, if the network provider supports it.

Before 3.0, this were enabled on all cards. However, if the IP stack is
disabled, this would mean that the entire DVB would also be disabled.
So, this option were added. It may make sense to make it dependent of
CONFIG_EMBEDDED, as normal users should not need to disable it.

Feel free to send us a patch if you want to improve the Kconfig logic or
help message.

Thanks,
Mauro

[PATCH] DVB: dvb-net, make the kconfig text helpful

[Jiri Slaby]

Telling the user they can disable an option if they want is not the
much useful. Describe what it is good for instead.

The text was derived from Mauro's email.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Petter Selasky <hselasky@c2i.net>
---
 drivers/media/Kconfig |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index dc61895..279e2b9 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -89,11 +89,13 @@ config DVB_NET
 	default (NET && INET)
 	depends on NET && INET
 	help
-	  The DVB network support in the DVB core can
-	  optionally be disabled if this
-	  option is set to N.
+	  This option enables DVB Network Support which is a part of the DVB
+	  standard. It is used, for example, by automatic firmware updates used
+	  on Set-Top-Boxes. It can also be used to access the Internet via the
+	  DVB card, if the network provider supports it.
 
-	  If unsure say Y.
+	  You may want to disable the network support on embedded devices. If
+	  unsure say Y.
 
 config VIDEO_MEDIA
 	tristate
-- 
1.7.5.4

Re: [PATCH] DVB: dvb-net, make the kconfig text helpful

[Randy Dunlap]

On Thu, 16 Jun 2011 21:06:56 +0200 Jiri Slaby wrote:

> Telling the user they can disable an option if they want is not the
> much useful. Describe what it is good for instead.
> 
> The text was derived from Mauro's email.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Hans Petter Selasky <hselasky@c2i.net>

Yes, much better.  Thanks.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

> ---
>  drivers/media/Kconfig |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index dc61895..279e2b9 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -89,11 +89,13 @@ config DVB_NET
>  	default (NET && INET)
>  	depends on NET && INET
>  	help
> -	  The DVB network support in the DVB core can
> -	  optionally be disabled if this
> -	  option is set to N.
> +	  This option enables DVB Network Support which is a part of the DVB
> +	  standard. It is used, for example, by automatic firmware updates used
> +	  on Set-Top-Boxes. It can also be used to access the Internet via the
> +	  DVB card, if the network provider supports it.
>  
> -	  If unsure say Y.
> +	  You may want to disable the network support on embedded devices. If
> +	  unsure say Y.
>  
>  config VIDEO_MEDIA
>  	tristate
> -- 
> 1.7.5.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] DVB: dvb-net, make the kconfig text helpful

[Hans Petter Selasky]

On Thursday 16 June 2011 21:06:56 Jiri Slaby wrote:
> Telling the user they can disable an option if they want is not the
> much useful. Describe what it is good for instead.
> 
> The text was derived from Mauro's email.

Acked-by: Hans Petter Selasky <hselasky@c2i.net>

PS: Don't forget the other patch to add a dependency to DVB_CORE.

--HPS

Re: [PATCH] DVB: dvb-net, make the kconfig text helpful

[Jiri Slaby]

On 06/17/2011 08:04 AM, Hans Petter Selasky wrote:
> PS: Don't forget the other patch to add a dependency to DVB_CORE.

Sorry, I'm not your fixing monkey. Fix your bugs on your own.

thanks,
-- 
js

Re: [PATCH] DVB: dvb-net, make the kconfig text helpful

[Hans Petter Selasky]

On Friday 17 June 2011 10:02:21 Jiri Slaby wrote:
> On 06/17/2011 08:04 AM, Hans Petter Selasky wrote:
> > PS: Don't forget the other patch to add a dependency to DVB_CORE.
> 
> Sorry, I'm not your fixing monkey. Fix your bugs on your own.

The PS was intended for Mauro. Sorry if you confused that.

--HPS