Re: Bug: media_build always compiles with '-DDEBUG'

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 20-06-2011 09:35, Laurent Pinchart escreveu:
> Hi Mauro,
> 
> On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote:
>> Em 19-06-2011 02:00, Helmut Auer escreveu:
>>> Am 18.06.2011 23:38, schrieb Oliver Endriss:
>>>> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote:
>>>>> Hi
>>>>>
>>>>>> Replacing
>>>>>>
>>>>>>       ifdef CONFIG_VIDEO_OMAP3_DEBUG
>>>>>>
>>>>>> by
>>>>>>
>>>>>>       ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y)
>>>>>>
>>>>>> would do the trick.
>>>>>
>>>>> I guess that would not ive the intended result.
>>>>> Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug
>>>>> messages in all media modules,
>>>>
>>>> True, but it will happen only if you manually enable
>>>> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig.
>>>>
>>>> You cannot avoid this without major changes of the
>>>> media_build system - imho not worth the effort.
>>>
>>> Then imho it would be better to drop the  CONFIG_VIDEO_OMAP3_DEBUG
>>> variable completely, you can set CONFIG_DEBUG which would give the same
>>> results.
>>
>> Good catch!
>>
>> Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG
>> variable completely. If someone wants to build with -DDEBUG, he can just
>> use CONFIG_DEBUG.
>>
>> Laurent,
>>
>> Any comments?
> 
> CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug mode, 
> without having to compile the whole kernel with debugging enabled. I'd like to 
> keep that feature if possible.

If you want that, build it using media_build. I don't care of having such hacks
there, but having it upstream is not the right thing to do.

Mauro