From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist
Date: Fri, 24 Jun 2011 20:11:51 -0300 [thread overview]
Message-ID: <4E0519B7.3000304@redhat.com> (raw)
Currently, -EINVAL is used to return either when an IOCTL is not
implemented, or if the ioctl was not implemented.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---
Documentation/DocBook/media/Makefile | 1 +
Documentation/DocBook/media/v4l/func-ioctl.xml | 17 +++++++++--------
drivers/media/video/v4l2-ioctl.c | 4 ++--
3 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/Documentation/DocBook/media/Makefile b/Documentation/DocBook/media/Makefile
index 8cb27f3..93722da 100644
--- a/Documentation/DocBook/media/Makefile
+++ b/Documentation/DocBook/media/Makefile
@@ -117,6 +117,7 @@ ERRORS = \
EPERM \
ERANGE \
EPIPE \
+ ENOIOCTLCMD \
ESCAPE = \
-e "s/&/\\&/g" \
diff --git a/Documentation/DocBook/media/v4l/func-ioctl.xml b/Documentation/DocBook/media/v4l/func-ioctl.xml
index b60fd37..0c97ba9 100644
--- a/Documentation/DocBook/media/v4l/func-ioctl.xml
+++ b/Documentation/DocBook/media/v4l/func-ioctl.xml
@@ -132,14 +132,15 @@ complete the request.</para>
&VIDIOC-S-CTRL; ioctl to a value which is out of bounds.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><errorcode>ENOIOCTLCMD</errorcode></term>
+ <listitem>
+ <para>The application attempted to use a non-existent ioctl. This is returned by the V4L2 core only.
+ Applications should be able to handle this error code, in order to detect if a new ioctl is
+ not implemented at the current Kernel version. Kernel versions lower than 3.0 returns EINVAL to
+ non-existing ioctl's.</para>
+ </listitem>
+ </varlistentry>
</variablelist>
</refsect1>
</refentry>
-
-<!--
-Local Variables:
-mode: sgml
-sgml-parent-document: "v4l2.sgml"
-indent-tabs-mode: nil
-End:
--->
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 61ac6bf..a0a2466 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/media/video/v4l2-ioctl.c
@@ -543,12 +543,12 @@ static long __video_do_ioctl(struct file *file,
struct v4l2_fh *vfh = NULL;
struct v4l2_format f_copy;
int use_fh_prio = 0;
- long ret = -EINVAL;
+ long ret = -ENOIOCTLCMD;
if (ops == NULL) {
printk(KERN_WARNING "videodev: \"%s\" has no ioctl_ops.\n",
vfd->name);
- return -EINVAL;
+ return ret;
}
if ((vfd->debug & V4L2_DEBUG_IOCTL) &&
next reply other threads:[~2011-06-24 23:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 23:11 Mauro Carvalho Chehab [this message]
2011-06-26 15:40 ` [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist Sakari Ailus
2011-06-26 16:20 ` Mauro Carvalho Chehab
2011-06-26 17:13 ` Arnd Bergmann
2011-06-26 17:30 ` Mauro Carvalho Chehab
2011-06-26 18:20 ` Arnd Bergmann
2011-06-26 18:51 ` Mauro Carvalho Chehab
2011-06-26 19:52 ` Arnd Bergmann
2011-06-27 5:38 ` Hans Verkuil
2011-06-27 12:02 ` Sakari Ailus
2011-06-27 12:17 ` Hans Verkuil
2011-06-27 13:54 ` Mauro Carvalho Chehab
2011-06-27 14:56 ` Hans Verkuil
2011-06-27 15:33 ` Mauro Carvalho Chehab
2011-06-27 16:14 ` Arnd Bergmann
2011-06-27 16:42 ` Mauro Carvalho Chehab
2011-06-27 17:07 ` Hans Verkuil
2011-06-27 20:37 ` Mauro Carvalho Chehab
2011-06-27 20:48 ` Linus Torvalds
2011-06-28 6:04 ` Hans Verkuil
2011-06-28 16:05 ` Linus Torvalds
2011-06-28 16:42 ` Alan Cox
2011-06-28 16:50 ` Arnd Bergmann
2011-06-29 12:34 ` Mauro Carvalho Chehab
2011-06-27 15:12 ` Andy Walls
2011-06-27 15:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0519B7.3000304@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox