Re: [git:xawtv3/master] xawtv: reenable its usage with webcam's

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 06/29/2011 09:27 PM, Mauro Carvalho Chehab wrote:

<snip>

>
> Anyway, it is fixed. I also made scantv to force for a TV device at auto mode, as it
> doesn't sense to scan for TV channels on devices without tuner.

Thanks for fixing this, 2 remarks wrt the auto patch for
scantv:

1) This bit should be #ifdef __linux__ since we only support
auto* on linux because of the sysfs dep:

@@ -149,6 +149,9 @@ main(int argc, char **argv)

      /* parse options */
      ng_init();
+    /* Autodetect devices */
+    ng_dev.video = "auto_tv";
+
      for (;;) {
  	if (-1 == (c = getopt(argc, argv, "hsadi:n:f:o:c:C:D:")))
  	    break;

2) The added return NULL in case no device can be found lacks
printing an error message:

@@ -568,6 +569,8 @@ static void *ng_vid_open_auto(struct ng_vid_driver *drv, char *devpath)

      /* Step 2: try grabber devices and webcams */
      if (!handle) {
+	if (!allow_grabber)
+	    return NULL;
  	device = NULL;
  	while (1) {
  	    device = get_associated_device(md, device, MEDIA_V4L_VIDEO, NULL, NONE);

I propose changing the return NULL, with a goto to the error print further down.

>  From my side, I don't intend to touch on xawtv any time soon. So, maybe we can wait
> for a couple days and release version 1.101.

Assuming the 2 things mentioned above get fixed that sounds like a good plan to me.

Regards,

Hans