Re: [git:xawtv3/master] xawtv: reenable its usage with webcam's

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 30-06-2011 09:35, Mauro Carvalho Chehab escreveu:
> Em 30-06-2011 07:55, Hans de Goede escreveu:

>> 1) This bit should be #ifdef __linux__ since we only support
>> auto* on linux because of the sysfs dep:
> 
> True, but instead of adding it on every place, the better would be to replace auto/auto_tv
> at the library, instead of adding the test at each place we change to auto mode.

I fixed it using this approach.

>> 2) The added return NULL in case no device can be found lacks
>> printing an error message:

>> I propose changing the return NULL, with a goto to the error print further down.
> 
> Yes, that sounds better to me.

The error message didn't look good, so I added an specific message for it.

Yet, IMO, we're being too verbose:

$ scantv 
vid-open-auto: failed to open an analog TV device at /dev/video0
vid-open: could not find a suitable videodev
no analog TV device available

Cheers,
Mauro