Re: [GIT PATCHES FOR 3.1] s5p-fimc and noon010pc30 drivers conversion to media controller API

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 08-07-2011 12:25, Sylwester Nawrocki escreveu:
> Hi Mauro,
> 
> The following changes since commit 6068c012c3741537c9f965be5b4249f989aa5efc:
> 
>   [media] v4l: Document V4L2 control endianness as machine endianness (2011-07-07 19:26:11 -0300)
> 
> are available in the git repository at:
>   git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-fimc-next
> 
> These patches convert FIMC and the sensor driver to media controller API,
> i.e. a top level media device is added to be able to manage at runtime
> attached sensors and all video processing entities present in the SoC.
> An additional subdev at FIMC capture driver exposes the scaler and
> composing functionality of the video capture IP.
> The previously existing functionality is entirely retained.
> 
> I have introduced a few changes comparing to the last version (v3) sent
> to the ML, as commented below.
> 
> Sylwester Nawrocki (28):
>       s5p-fimc: Add support for runtime PM in the mem-to-mem driver
>       s5p-fimc: Add media entity initialization
>       s5p-fimc: Remove registration of video nodes from probe()

That patch seems weird for me. If they aren't registered at probe,
when they're registered?

>       s5p-fimc: Remove sclk_cam clock handling
>       s5p-fimc: Limit number of available inputs to one

Camera sensors at FIMC input are no longer selected with S_INPUT ioctl.
They will be attached to required FIMC entity through pipeline
re-configuration at the media device level.

Why? The proper way to select an input is via S_INPUT. The driver may also
optionally allow changing it via the media device, but it should not be
a mandatory requirement, as the media device API is optional.

>       s5p-fimc: Remove sensor management code from FIMC capture driver
>       s5p-fimc: Remove v4l2_device from video capture and m2m driver
>       s5p-fimc: Add the media device driver
>       s5p-fimc: Conversion to use struct v4l2_fh
> 	-> removed the check of return value from v4l2_fh_init as its
> 	   signature has changed
> 
>       s5p-fimc: Conversion to the control framework
>       s5p-fimc: Add media operations in the capture entity driver
>       s5p-fimc: Add PM helper function for streaming control
>       s5p-fimc: Correct color format enumeration
>       s5p-fimc: Convert to use media pipeline operations



>       s5p-fimc: Add subdev for the FIMC processing block
> 	-> added setting of a default capture format in device open()
> 
>       s5p-fimc: Add support for camera capture in JPEG format
>       s5p-fimc: Add v4l2_device notification support for single frame capture
>       s5p-fimc: Use consistent names for the buffer list functions
>       s5p-fimc: Add runtime PM support in the camera capture driver
>       s5p-fimc: Correct crop offset alignment on exynos4
>       s5p-fimc: Remove single-planar capability flags
>       noon010pc30: Do not ignore errors in initial controls setup
>       noon010pc30: Convert to the pad level ops
> 	-> removed unused variable and pad number prerequisite check 
> 	   in noon010_set_fmt
> 
>       noon010pc30: Clean up the s_power callback
>       noon010pc30: Remove g_chip_ident operation handler
>       s5p-csis: Handle all available power supplies
> 	-> renamed 'supply' to 'supplies' in s5p-csis as per Laurent's
> 	   suggestion
> 
>       s5p-csis: Rework of the system suspend/resume helpers
>       s5p-csis: Enable v4l subdev device node
> 
>  drivers/media/video/Kconfig                 |    4 +-
>  drivers/media/video/noon010pc30.c           |  173 ++--
>  drivers/media/video/s5p-fimc/Makefile       |    2 +-
>  drivers/media/video/s5p-fimc/fimc-capture.c | 1424 +++++++++++++++++++--------
>  drivers/media/video/s5p-fimc/fimc-core.c    | 1119 +++++++++++----------
>  drivers/media/video/s5p-fimc/fimc-core.h    |  222 +++--
>  drivers/media/video/s5p-fimc/fimc-mdevice.c |  859 ++++++++++++++++
>  drivers/media/video/s5p-fimc/fimc-mdevice.h |  118 +++
>  drivers/media/video/s5p-fimc/fimc-reg.c     |   76 +-
>  drivers/media/video/s5p-fimc/mipi-csis.c    |   84 +-
>  drivers/media/video/s5p-fimc/regs-fimc.h    |    8 +-
>  include/media/s5p_fimc.h                    |   11 +
>  include/media/v4l2-chip-ident.h             |    3 -
>  13 files changed, 2921 insertions(+), 1182 deletions(-)
>  create mode 100644 drivers/media/video/s5p-fimc/fimc-mdevice.c
>  create mode 100644 drivers/media/video/s5p-fimc/fimc-mdevice.h
> 
> 
> Regards,