From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34667 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932558Ab1GNXa2 (ORCPT ); Thu, 14 Jul 2011 19:30:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6ENUROi010107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jul 2011 19:30:27 -0400 Message-ID: <4E1F7C11.1050608@redhat.com> Date: Thu, 14 Jul 2011 20:30:25 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Jarod Wilson CC: linux-media@vger.kernel.org Subject: Re: [PATCH 2/9] [media] mceusb: give hardware time to reply to cmds References: <1310681394-3530-1-git-send-email-jarod@redhat.com> <1310681394-3530-3-git-send-email-jarod@redhat.com> In-Reply-To: <1310681394-3530-3-git-send-email-jarod@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 14-07-2011 19:09, Jarod Wilson escreveu: > Sometimes the init routine is blasting commands out to the hardware > faster than it can reply. Throw a brief delay in there to give the > hardware a chance to reply before we send the next command. > > Signed-off-by: Jarod Wilson > --- > drivers/media/rc/mceusb.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c > index 111bead..13a853b 100644 > --- a/drivers/media/rc/mceusb.c > +++ b/drivers/media/rc/mceusb.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > #include > > #define DRIVER_VERSION "1.91" > @@ -735,6 +736,7 @@ static void mce_request_packet(struct mceusb_dev *ir, unsigned char *data, > static void mce_async_out(struct mceusb_dev *ir, unsigned char *data, int size) > { > mce_request_packet(ir, data, size, MCEUSB_TX); > + mdelay(10); Can't it be a msleep() instead? Delays spend more power, and keeps the CPU busy while running. > } > > static void mce_flush_rx_buffer(struct mceusb_dev *ir, int size) Cheers, Mauro