From: Jarod Wilson <jarod@redhat.com>
To: linux-media@vger.kernel.org
Cc: Andy Walls <awalls@md.metrocast.net>, Chris W <lkml@psychogeeks.com>
Subject: Re: [PATCH] [media] imon: don't submit urb before rc_dev set up
Date: Fri, 22 Jul 2011 10:06:51 -0400 [thread overview]
Message-ID: <4E2983FB.3040301@redhat.com> (raw)
In-Reply-To: <1311007609-28210-1-git-send-email-jarod@redhat.com>
Jarod Wilson wrote:
> The interface 0 urb callback was being wired up before the rc_dev device
> was allocated, meaning the callback could be called with a null rc_dev,
> leading to an oops. This likely only ever happens on the older 0xffdc
> SoundGraph devices, which continually trigger interrupts even when they
> have no valid keydata, and the window in which it could happen is small,
> but its actually happening regularly for at least one user, and its an
> obvious fix. Compile and sanity-tested with one of my own imon devices.
Explicit self-nak on this one, just to crystal-clear, since this is
handled without breaking ffdc device detection by a later patch.
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2011-07-22 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E1B978C.2030407@psychogeeks.com>
2011-07-12 15:03 ` Imon module Oops and kernel hang Randy Dunlap
2011-07-12 19:55 ` Jarod Wilson
2011-07-12 22:35 ` Chris W
2011-07-13 4:20 ` Jarod Wilson
2011-07-13 5:42 ` Chris W
2011-07-13 22:11 ` Jarod Wilson
2011-07-14 2:41 ` Chris W
2011-07-17 0:43 ` Andy Walls
2011-07-17 1:38 ` Chris W
2011-07-17 13:36 ` Andy Walls
2011-07-18 15:04 ` Jarod Wilson
2011-07-18 16:46 ` [PATCH] [media] imon: don't submit urb before rc_dev set up Jarod Wilson
2011-07-18 22:29 ` Chris W
2011-07-19 12:23 ` Jarod Wilson
2011-07-19 16:12 ` [PATCH] [media] imon: don't parse scancodes until intf configured Jarod Wilson
2011-07-19 22:05 ` Chris W
2011-07-20 13:18 ` Jarod Wilson
2011-07-20 22:56 ` Chris W
2011-07-26 17:57 ` Jarod Wilson
2011-07-22 14:06 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2983FB.3040301@redhat.com \
--to=jarod@redhat.com \
--cc=awalls@md.metrocast.net \
--cc=linux-media@vger.kernel.org \
--cc=lkml@psychogeeks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox