Re: [patch][saa7134] do not change mute state for capturing audio

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Em 23-07-2011 04:44, Stas Sergeev escreveu:
> 23.07.2011 05:28, Mauro Carvalho Chehab wrote:
>> Mplayer was just one example of an application that I know
>> it doesn't call V4L2_CID_AUDIO_MUTE to unmute.
> I would suggest fixing all such an apps, even if we
> are not going to change that in the driver.

If application needs to change due to a patch, this is a
regression, as it will break binary compatibility with
non-patched versions. NACK.

>> Your approach of moving it to VIDIOC_S_FREQUENCY (if I
>> understood well) won't work, as, every time someone would
>> change the channel, it will be unmuted, causing troubles
>> on applications like "scantv" (part of xawtv).
> But how can scantv (or anything else) rely on the
> fact that the board was muted when that app starts?
> I guess it can't, and mutes it explicitly first, no?

Even if it mutes, every time a channel is changed, it
will be unmuted, if you put such unmute logic at
VIDIOC_S_FREQUENCY.

Mauro.