public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Alina Friedrichsen <x-alina@gmx.net>
Cc: linux-media@vger.kernel.org, rglowery@exemail.com.au
Subject: Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028
Date: Thu, 28 Jul 2011 16:38:54 -0300	[thread overview]
Message-ID: <4E31BACE.2060809@redhat.com> (raw)
In-Reply-To: <20110722183552.169950@gmx.net>

Alina,

Em 22-07-2011 15:35, Alina Friedrichsen escreveu:
> Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work
> anymore, and nobody feels responsible to fix it.

Could you please check if the enclosed patch fixes the tuner issue?

Use it instead of the patch you've made. If it doesn't work, please send us
the dmesg logs with tuner-xc2028 debug enabled.

Thanks!
Mauro

-

cx23885-dvb: Fix demod IF

This device is not using the proper demod IF. Instead of using the
IF macro, it is specifying a IF frequency. This doesn't work, as xc3028
needs to load an specific SCODE for the tuner. In this case, there's
no IF table for 5 MHz.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index ad2fd13..168142e 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -844,7 +844,7 @@ static int dvb_register(struct cx23885_tsport *port)
 			static struct xc2028_ctrl ctl = {
 				.fname   = XC3028L_DEFAULT_FIRMWARE,
 				.max_len = 64,
-				.demod   = 5000,
+				.demod   = XC3028_FE_DIBCOM52,
 				/* This is true for all demods with
 					v36 firmware? */
 				.type    = XC2028_D2633,



  parent reply	other threads:[~2011-07-28 19:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 18:35 [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028 Alina Friedrichsen
2011-07-27 14:34 ` Mauro Carvalho Chehab
2011-07-27 14:58   ` Devin Heitmueller
2011-07-27 15:50     ` Mauro Carvalho Chehab
2011-07-27 16:06     ` Mauro Carvalho Chehab
2011-07-28 19:38 ` Mauro Carvalho Chehab [this message]
2011-07-29  6:49   ` Alina Friedrichsen
  -- strict thread matches above, loose matches on Subject: below --
2011-08-01 14:55 jean.bruenn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E31BACE.2060809@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rglowery@exemail.com.au \
    --cc=x-alina@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox