From: Antti Palosaari <crope@iki.fi>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Chris Rankin <rankincj@yahoo.com>, linux-media@vger.kernel.org
Subject: Re: PCTV 290e nanostick and remote control support
Date: Sun, 14 Aug 2011 15:11:46 +0300 [thread overview]
Message-ID: <4E47BB82.8040801@iki.fi> (raw)
In-Reply-To: <CAGoCfiw0p7jwac94eYM9apUN4Qd8mduteq_xH8ePoyxvO7SNGA@mail.gmail.com>
On 08/14/2011 04:48 AM, Devin Heitmueller wrote:
> On Sat, Aug 13, 2011 at 9:43 PM, Chris Rankin <rankincj@yahoo.com> wrote:
>> The rc-pinnacle-pctv-hd keymap is missing the definition of the OK key:
>>
>> --- linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c.orig 2011-08-14 02:42:01.000000000 +0100
>> +++ linux-3.0/drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.c 2011-08-14 02:12:45.000000000 +0100
>> @@ -20,6 +20,7 @@
>> { 0x0701, KEY_MENU }, /* Pinnacle logo */
>> { 0x0739, KEY_POWER },
>> { 0x0703, KEY_VOLUMEUP },
>> + { 0x0705, KEY_OK },
>> { 0x0709, KEY_VOLUMEDOWN },
>> { 0x0706, KEY_CHANNELUP },
>> { 0x070c, KEY_CHANNELDOWN },
>>
>> Cheers,
>> Chris
>
> Wow, how the hell did I miss that? I did numerous remotes for em28xx
> based devices that use that RC profile, and never noticed that issue.
>
> Will have to check the merge logs. Maybe the key got lost when they
> refactored the IR support.
It seems to be very old bug, year 2007, not coming from merge errors! It
could be even possible there have not been such button originally. Very
weird situation none have found it earlier. For example I just pressed
few buttons to see number are coming to console => OK it works (didn't
looked all buttons sends events).
That's commit which adds those keytables:
commit 54d75ebaa02809f24a16624e32706af3bf97588e
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2011-08-14 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 19:36 PCTV 290e nanostick and remote control support Chris Rankin
2011-08-13 22:31 ` Antti Palosaari
2011-08-14 0:39 ` Chris Rankin
2011-08-14 1:43 ` Chris Rankin
2011-08-14 1:48 ` Devin Heitmueller
2011-08-14 12:11 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E47BB82.8040801@iki.fi \
--to=crope@iki.fi \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox