From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 16/21] [staging] tm6000: Select interface on first open.
Date: Wed, 31 Aug 2011 17:02:18 -0300 [thread overview]
Message-ID: <4E5E934A.7000500@redhat.com> (raw)
In-Reply-To: <1312442059-23935-17-git-send-email-thierry.reding@avionic-design.de>
Em 04-08-2011 04:14, Thierry Reding escreveu:
> Instead of selecting the default interface setting when preparing
> isochronous transfers, select it on the first call to open() to make
> sure it is available earlier.
Hmm... I fail to see what this is needed earlier. The ISOC endpont is used
only when the device is streaming.
Did you get any bug related to it? If so, please describe it better.
> ---
> drivers/staging/tm6000/tm6000-video.c | 17 ++++++++++++-----
> 1 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
> index 70fc19e..b59a0da 100644
> --- a/drivers/staging/tm6000/tm6000-video.c
> +++ b/drivers/staging/tm6000/tm6000-video.c
> @@ -595,11 +595,6 @@ static int tm6000_prepare_isoc(struct tm6000_core *dev)
> tm6000_uninit_isoc(dev);
> /* Stop interrupt USB pipe */
> tm6000_ir_int_stop(dev);
> -
> - usb_set_interface(dev->udev,
> - dev->isoc_in.bInterfaceNumber,
> - dev->isoc_in.bAlternateSetting);
> -
> /* Start interrupt USB pipe */
> tm6000_ir_int_start(dev);
>
> @@ -1484,6 +1479,18 @@ static int tm6000_open(struct file *file)
> break;
> }
>
> + if (dev->users == 0) {
> + int err = usb_set_interface(dev->udev,
> + dev->isoc_in.bInterfaceNumber,
> + dev->isoc_in.bAlternateSetting);
> + if (err < 0) {
> + dev_err(&vdev->dev, "failed to select interface %d, "
> + "alt. setting %d\n",
> + dev->isoc_in.bInterfaceNumber,
> + dev->isoc_in.bAlternateSetting);
> + }
> + }
> +
> /* If more than one user, mutex should be added */
> dev->users++;
>
next prev parent reply other threads:[~2011-08-31 20:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 7:13 [PATCH 00/21] [staging] tm6000: Assorted fixes and improvements Thierry Reding
2011-08-04 7:13 ` [PATCH 01/21] [media] tuner/xc2028: Add I2C flush callback Thierry Reding
2011-08-04 7:14 ` [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode Thierry Reding
2011-08-31 18:32 ` Mauro Carvalho Chehab
2011-09-01 5:10 ` Thierry Reding
2011-09-01 12:45 ` Andrew Goff
2011-09-01 14:31 ` Mauro Carvalho Chehab
2011-09-02 8:19 ` Thierry Reding
2011-12-31 0:31 ` Javier S. Pedro
2011-08-04 7:14 ` [PATCH 03/21] [staging] tm6000: Miscellaneous cleanups Thierry Reding
2011-08-04 7:14 ` [PATCH 04/21] [staging] tm6000: Use correct input in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 05/21] [staging] tm6000: Implement I2C flush callback Thierry Reding
2011-08-04 7:14 ` [PATCH 06/21] [staging] tm6000: Increase maximum I2C packet size Thierry Reding
2011-08-31 19:45 ` Mauro Carvalho Chehab
2011-09-01 5:08 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 07/21] [staging] tm6000: Remove artificial delay Thierry Reding
2011-08-31 19:50 ` Mauro Carvalho Chehab
2011-09-01 5:13 ` Thierry Reding
2011-09-01 5:47 ` Mauro Carvalho Chehab
2011-09-01 6:27 ` [PATCH 1/2] [media] tm6000: Add fast USB access quirk Thierry Reding
2011-09-01 6:27 ` [PATCH 2/2] [media] tm6000: Enable fast USB quirk on Cinergy Hybrid Thierry Reding
2011-09-01 6:33 ` [PATCH 1/2] [media] tm6000: Add fast USB access quirk Thierry Reding
2011-09-01 6:43 ` [PATCH v2 " Thierry Reding
2011-09-01 6:43 ` [PATCH v2 2/2] [media] tm6000: Enable fast USB quirk on Cinergy Hybrid Thierry Reding
2011-08-04 7:14 ` [PATCH 08/21] [staging] tm6000: Flesh out the IRQ callback Thierry Reding
2011-08-04 7:14 ` [PATCH 09/21] [staging] tm6000: Rename active interface register Thierry Reding
2011-08-04 7:14 ` [PATCH 10/21] [staging] tm6000: Disable video interface in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 11/21] [staging] tm6000: Rework standard register tables Thierry Reding
2011-08-04 7:14 ` [PATCH 12/21] [staging] tm6000: Add locking for USB transfers Thierry Reding
2011-08-04 7:14 ` [PATCH 13/21] [staging] tm6000: Properly count device usage Thierry Reding
2011-08-04 7:14 ` [PATCH 14/21] [staging] tm6000: Initialize isochronous transfers only once Thierry Reding
2011-08-04 7:14 ` [PATCH 15/21] [staging] tm6000: Execute lightweight reset on close Thierry Reding
2011-08-31 20:53 ` Mauro Carvalho Chehab
[not found] ` <4E5EAA41.4060502@redhat.com>
2011-09-01 5:24 ` Thierry Reding
2011-09-03 17:17 ` Mauro Carvalho Chehab
2011-09-05 5:38 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 16/21] [staging] tm6000: Select interface on first open Thierry Reding
2011-08-31 20:02 ` Mauro Carvalho Chehab [this message]
2011-09-01 5:19 ` Thierry Reding
2011-09-01 5:53 ` Mauro Carvalho Chehab
2011-09-01 6:10 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 17/21] [staging] tm6000: Do not use video buffers in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 18/21] [staging] tm6000: Plug memory leak on PCM free Thierry Reding
2011-08-04 7:14 ` [PATCH 19/21] [staging] tm6000: Enable audio clock in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 20/21] [staging] tm6000: Enable radio mode for Cinergy Hybrid XE Thierry Reding
2011-08-04 7:14 ` [PATCH 21/21] [staging] tm6000: Remove unnecessary workaround Thierry Reding
2011-08-31 12:41 ` [PATCH 00/21] [staging] tm6000: Assorted fixes and improvements Mauro Carvalho Chehab
2011-08-31 13:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5E934A.7000500@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).