From: Andrew Goff <goffa72@gmail.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.
Date: Thu, 01 Sep 2011 22:45:37 +1000 [thread overview]
Message-ID: <4E5F7E71.5010209@aapt.net.au> (raw)
In-Reply-To: <20110901051037.GB18473@avionic-0098.mockup.avionic-design.de>
Hi Thierry,
I have been having problems with the radio tuner in my leadtek 1800h
card. This card has the xc2028 tuner. Using fmtools i would get an error
message similar to - frequency out of range 0.0 - 0.0.
After seeing you patches at the beginning of last month I installed the
recent drivers at the time and applied your patches. The frequency out
of range error went away but the only sound I got was static. I then
discovered the frequency is out by 2.7MHz, so if I want to listen to
104.9 I need to tune the radio to 107.6.
On Ubuntu 10.04 the card works fine, the errors started when applying
the recent V4L drivers that I require for another card.
Are you able to help resolve this problem and get this card working
properly again.
Thanks
Andrew
On 1/09/2011 3:10 PM, Thierry Reding wrote:
> * Mauro Carvalho Chehab wrote:
>> Em 04-08-2011 04:14, Thierry Reding escreveu:
>>> In radio mode, no frequency offset is needed. While at it, split off the
>>> frequency offset computation for digital TV into a separate function.
>>
>> Nah, it is better to keep the offset calculation there. there is already
>> a set_freq for DVB. breaking the frequency logic even further seems to
>> increase the driver's logic. Also, patch is simpler and easier to review.
>
> Okay, no problem. Feel free to replace the patch with yours.
>
>> The patch bellow seems to be better. On a quick review, I think that the
>> send_seq(priv, {0x00, 0x00})
>> sequence may be wrong. I suspect that the device is just discarding that,
>> but changing it needs more testing.
>
> I ran across that as well, but I didn't dare touch it because I wasn't sure
> what the broader impact would be.
>
> Thierry
next prev parent reply other threads:[~2011-09-01 12:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 7:13 [PATCH 00/21] [staging] tm6000: Assorted fixes and improvements Thierry Reding
2011-08-04 7:13 ` [PATCH 01/21] [media] tuner/xc2028: Add I2C flush callback Thierry Reding
2011-08-04 7:14 ` [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode Thierry Reding
2011-08-31 18:32 ` Mauro Carvalho Chehab
2011-09-01 5:10 ` Thierry Reding
2011-09-01 12:45 ` Andrew Goff [this message]
2011-09-01 14:31 ` Mauro Carvalho Chehab
2011-09-02 8:19 ` Thierry Reding
2011-12-31 0:31 ` Javier S. Pedro
2011-08-04 7:14 ` [PATCH 03/21] [staging] tm6000: Miscellaneous cleanups Thierry Reding
2011-08-04 7:14 ` [PATCH 04/21] [staging] tm6000: Use correct input in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 05/21] [staging] tm6000: Implement I2C flush callback Thierry Reding
2011-08-04 7:14 ` [PATCH 06/21] [staging] tm6000: Increase maximum I2C packet size Thierry Reding
2011-08-31 19:45 ` Mauro Carvalho Chehab
2011-09-01 5:08 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 07/21] [staging] tm6000: Remove artificial delay Thierry Reding
2011-08-31 19:50 ` Mauro Carvalho Chehab
2011-09-01 5:13 ` Thierry Reding
2011-09-01 5:47 ` Mauro Carvalho Chehab
2011-09-01 6:27 ` [PATCH 1/2] [media] tm6000: Add fast USB access quirk Thierry Reding
2011-09-01 6:27 ` [PATCH 2/2] [media] tm6000: Enable fast USB quirk on Cinergy Hybrid Thierry Reding
2011-09-01 6:33 ` [PATCH 1/2] [media] tm6000: Add fast USB access quirk Thierry Reding
2011-09-01 6:43 ` [PATCH v2 " Thierry Reding
2011-09-01 6:43 ` [PATCH v2 2/2] [media] tm6000: Enable fast USB quirk on Cinergy Hybrid Thierry Reding
2011-08-04 7:14 ` [PATCH 08/21] [staging] tm6000: Flesh out the IRQ callback Thierry Reding
2011-08-04 7:14 ` [PATCH 09/21] [staging] tm6000: Rename active interface register Thierry Reding
2011-08-04 7:14 ` [PATCH 10/21] [staging] tm6000: Disable video interface in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 11/21] [staging] tm6000: Rework standard register tables Thierry Reding
2011-08-04 7:14 ` [PATCH 12/21] [staging] tm6000: Add locking for USB transfers Thierry Reding
2011-08-04 7:14 ` [PATCH 13/21] [staging] tm6000: Properly count device usage Thierry Reding
2011-08-04 7:14 ` [PATCH 14/21] [staging] tm6000: Initialize isochronous transfers only once Thierry Reding
2011-08-04 7:14 ` [PATCH 15/21] [staging] tm6000: Execute lightweight reset on close Thierry Reding
2011-08-31 20:53 ` Mauro Carvalho Chehab
[not found] ` <4E5EAA41.4060502@redhat.com>
2011-09-01 5:24 ` Thierry Reding
2011-09-03 17:17 ` Mauro Carvalho Chehab
2011-09-05 5:38 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 16/21] [staging] tm6000: Select interface on first open Thierry Reding
2011-08-31 20:02 ` Mauro Carvalho Chehab
2011-09-01 5:19 ` Thierry Reding
2011-09-01 5:53 ` Mauro Carvalho Chehab
2011-09-01 6:10 ` Thierry Reding
2011-08-04 7:14 ` [PATCH 17/21] [staging] tm6000: Do not use video buffers in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 18/21] [staging] tm6000: Plug memory leak on PCM free Thierry Reding
2011-08-04 7:14 ` [PATCH 19/21] [staging] tm6000: Enable audio clock in radio mode Thierry Reding
2011-08-04 7:14 ` [PATCH 20/21] [staging] tm6000: Enable radio mode for Cinergy Hybrid XE Thierry Reding
2011-08-04 7:14 ` [PATCH 21/21] [staging] tm6000: Remove unnecessary workaround Thierry Reding
2011-08-31 12:41 ` [PATCH 00/21] [staging] tm6000: Assorted fixes and improvements Mauro Carvalho Chehab
2011-08-31 13:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F7E71.5010209@aapt.net.au \
--to=goffa72@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).