* ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
@ 2011-09-04 23:46 Antti Palosaari
2011-09-05 0:15 ` Chris Rankin
2011-09-05 0:24 ` Chris Rankin
0 siblings, 2 replies; 7+ messages in thread
From: Antti Palosaari @ 2011-09-04 23:46 UTC (permalink / raw)
To: Chris Rankin, Mauro Carvalho Chehab, linux-media
Moikka,
Current linux-media make gives error. Any idea what's wrong?
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 1907 modules
ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko]
undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-04 23:46 ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! Antti Palosaari
@ 2011-09-05 0:15 ` Chris Rankin
2011-09-05 0:24 ` Antti Palosaari
2011-09-05 0:24 ` Chris Rankin
1 sibling, 1 reply; 7+ messages in thread
From: Chris Rankin @ 2011-09-05 0:15 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media
On 05/09/11 00:46, Antti Palosaari wrote:
> Moikka,
> Current linux-media make gives error. Any idea what's wrong?
>
>
> Kernel: arch/x86/boot/bzImage is ready (#1)
> Building modules, stage 2.
> MODPOST 1907 modules
> ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
> WARNING: modpost: Found 2 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
The function em28xx_add_into_devlist() should have been deleted as part of this
change:
http://git.linuxtv.org/media_tree.git?a=commitdiff;h=6c03e38b34dcfcdfa2f10cf984995a48f030f039
Its only reference should have been removed at the same time.
Cheers,
Chris
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-04 23:46 ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! Antti Palosaari
2011-09-05 0:15 ` Chris Rankin
@ 2011-09-05 0:24 ` Chris Rankin
1 sibling, 0 replies; 7+ messages in thread
From: Chris Rankin @ 2011-09-05 0:24 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media
On 05/09/11 00:46, Antti Palosaari wrote:
> Moikka,
> Current linux-media make gives error. Any idea what's wrong?
>
>
> Kernel: arch/x86/boot/bzImage is ready (#1)
> Building modules, stage 2.
> MODPOST 1907 modules
> ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
> WARNING: modpost: Found 2 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
I think I see what's happened here. An extra reference to
em28xx_add_into_devlist() has been added to em28xx_init_dev() at line 2888. This
reference can be deleted because em28xx_init_extension() has been modified to
add the struct em28xx to the devlist and then pass it to each extension's init()
function all as a single operation.
Cheers,
Chris
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-05 0:15 ` Chris Rankin
@ 2011-09-05 0:24 ` Antti Palosaari
2011-09-05 0:34 ` Chris Rankin
0 siblings, 1 reply; 7+ messages in thread
From: Antti Palosaari @ 2011-09-05 0:24 UTC (permalink / raw)
To: Chris Rankin; +Cc: Mauro Carvalho Chehab, linux-media
On 09/05/2011 03:15 AM, Chris Rankin wrote:
> On 05/09/11 00:46, Antti Palosaari wrote:
>> Moikka,
>> Current linux-media make gives error. Any idea what's wrong?
>>
>>
>> Kernel: arch/x86/boot/bzImage is ready (#1)
>> Building modules, stage 2.
>> MODPOST 1907 modules
>> ERROR: "em28xx_add_into_devlist"
>> [drivers/media/video/em28xx/em28xx.ko] undefined!
>> WARNING: modpost: Found 2 section mismatch(es).
>> To see full details build your kernel with:
>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>
> The function em28xx_add_into_devlist() should have been deleted as part
> of this change:
>
> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=6c03e38b34dcfcdfa2f10cf984995a48f030f039
>
>
> Its only reference should have been removed at the same time.
git grep m28xx_add_into_devlis drivers/media/
drivers/media/video/em28xx/em28xx-cards.c:
em28xx_add_into_devlist(dev);
drivers/media/video/em28xx/em28xx.h:void em28xx_add_into_devlist(struct
em28xx *dev);
If you select em28xx-cards.c blob link you give you can see it is there
still for some reason.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-05 0:24 ` Antti Palosaari
@ 2011-09-05 0:34 ` Chris Rankin
2011-09-05 13:57 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 7+ messages in thread
From: Chris Rankin @ 2011-09-05 0:34 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media
On 05/09/11 01:24, Antti Palosaari wrote:
> If you select em28xx-cards.c blob link you give you can see it is there still
> for some reason.
It's a merge issue. This lingering reference must have been added after I posted
my original patch. Fortunately, it's easily fixed: the
list_add_tail(&dev->devlist, &em28xx_devlist);
operation is now done by ex28xx_init_extension() instead, meaning we only take
the devlist mutex once. So that last em28xx_add_into_devlist() reference is
obsolete.
Cheers,
Chris
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-05 0:34 ` Chris Rankin
@ 2011-09-05 13:57 ` Mauro Carvalho Chehab
2011-09-05 14:26 ` Chris Rankin
0 siblings, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2011-09-05 13:57 UTC (permalink / raw)
To: Chris Rankin; +Cc: Antti Palosaari, linux-media
Em 04-09-2011 21:34, Chris Rankin escreveu:
> On 05/09/11 01:24, Antti Palosaari wrote:
>> If you select em28xx-cards.c blob link you give you can see it is there still
>> for some reason.
>
> It's a merge issue. This lingering reference must have been added after I posted my original patch. Fortunately, it's easily fixed: the
>
> list_add_tail(&dev->devlist, &em28xx_devlist);
>
> operation is now done by ex28xx_init_extension() instead, meaning we only take the devlist mutex once. So that last em28xx_add_into_devlist() reference is obsolete.
Could you please provide me a patch for it? I'll merge with your original one
when submitting it upstream.
>
> Cheers,
> Chris
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
2011-09-05 13:57 ` Mauro Carvalho Chehab
@ 2011-09-05 14:26 ` Chris Rankin
0 siblings, 0 replies; 7+ messages in thread
From: Chris Rankin @ 2011-09-05 14:26 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Antti Palosaari, linux-media
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
On 05/09/11 14:57, Mauro Carvalho Chehab wrote:
> Could you please provide me a patch for it? I'll merge with your original one
> when submitting it upstream.
Here you go. Did you also pick up the other merge fix and the (separate) memory
leak fix, please?
Cheers,
Chris
Signed-off-by: Chris Rankin <rankincj@yahoo.com>
[-- Attachment #2: EM28xx-devlist-merge-fix.diff --]
[-- Type: text/x-patch, Size: 354 bytes --]
--- linux/drivers/media/video/em28xx/em28xx-cards.c.orig 2011-09-05 15:21:38.000000000 +0100
+++ linux/drivers/media/video/em28xx/em28xx-cards.c 2011-09-05 15:21:55.000000000 +0100
@@ -2885,7 +2885,6 @@
retval = em28xx_audio_setup(dev);
if (retval)
return -ENODEV;
- em28xx_add_into_devlist(dev);
em28xx_init_extension(dev);
return 0;
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-09-05 14:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-04 23:46 ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! Antti Palosaari
2011-09-05 0:15 ` Chris Rankin
2011-09-05 0:24 ` Antti Palosaari
2011-09-05 0:34 ` Chris Rankin
2011-09-05 13:57 ` Mauro Carvalho Chehab
2011-09-05 14:26 ` Chris Rankin
2011-09-05 0:24 ` Chris Rankin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox