From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Chris Rankin <rankincj@yahoo.com>
Cc: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
Date: Mon, 05 Sep 2011 10:57:58 -0300 [thread overview]
Message-ID: <4E64D566.4070105@redhat.com> (raw)
In-Reply-To: <4E64192E.7060505@yahoo.com>
Em 04-09-2011 21:34, Chris Rankin escreveu:
> On 05/09/11 01:24, Antti Palosaari wrote:
>> If you select em28xx-cards.c blob link you give you can see it is there still
>> for some reason.
>
> It's a merge issue. This lingering reference must have been added after I posted my original patch. Fortunately, it's easily fixed: the
>
> list_add_tail(&dev->devlist, &em28xx_devlist);
>
> operation is now done by ex28xx_init_extension() instead, meaning we only take the devlist mutex once. So that last em28xx_add_into_devlist() reference is obsolete.
Could you please provide me a patch for it? I'll merge with your original one
when submitting it upstream.
>
> Cheers,
> Chris
>
next prev parent reply other threads:[~2011-09-05 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 23:46 ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! Antti Palosaari
2011-09-05 0:15 ` Chris Rankin
2011-09-05 0:24 ` Antti Palosaari
2011-09-05 0:34 ` Chris Rankin
2011-09-05 13:57 ` Mauro Carvalho Chehab [this message]
2011-09-05 14:26 ` Chris Rankin
2011-09-05 0:24 ` Chris Rankin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64D566.4070105@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox