checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Antti Palosaari]

I am almost sure this have been working earlier, but now it seems like 
nothing is acceptable for checkpatch.pl! I did surely about 20 --amend 
and tried to remove everything, without luck. Could someone point out 
whats new acceptable logging format for checkpatch.pl ?

[crope@localhost linux]$ git show 
1b19e42952963ae2a09a655f487de15b7c81c5b7 |./scripts/checkpatch.pl -
WARNING: Do not use whitespace before Signed-off-by:
#10:
     Signed-off-by: Joe Perches <joe@perches.com>

WARNING: Do not use whitespace before Signed-off-by:
#11:
     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

total: 0 errors, 2 warnings, 48 lines checked

Your patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


Antti
-- 
http://palosaari.fi/

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Bjørn Mork]

Antti Palosaari <crope@iki.fi> writes:

> I am almost sure this have been working earlier, but now it seems like
> nothing is acceptable for checkpatch.pl! I did surely about 20 --amend
> and tried to remove everything, without luck. Could someone point out
> whats new acceptable logging format for checkpatch.pl ?
>
> [crope@localhost linux]$ git show
> 1b19e42952963ae2a09a655f487de15b7c81c5b7 |./scripts/checkpatch.pl -
> WARNING: Do not use whitespace before Signed-off-by:

Don't know if checkpatch used to accept that, but you can use
"--format=email" to make it work with git show:

 bjorn@canardo:/usr/local/src/git/linux$ git show --format=email 1b19e42952963ae2a09a655f487de15b7c81c5b7|./scripts/checkpatch.pl -
 total: 0 errors, 0 warnings, 48 lines checked

 Your patch has no obvious style problems and is ready for submission.



Bjørn

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Antti Palosaari]

On 09/06/2011 10:50 AM, Bjørn Mork wrote:
> Antti Palosaari<crope@iki.fi>  writes:
>
>> I am almost sure this have been working earlier, but now it seems like
>> nothing is acceptable for checkpatch.pl! I did surely about 20 --amend
>> and tried to remove everything, without luck. Could someone point out
>> whats new acceptable logging format for checkpatch.pl ?
>>
>> [crope@localhost linux]$ git show
>> 1b19e42952963ae2a09a655f487de15b7c81c5b7 |./scripts/checkpatch.pl -
>> WARNING: Do not use whitespace before Signed-off-by:
>
> Don't know if checkpatch used to accept that, but you can use
> "--format=email" to make it work with git show:
>
>   bjorn@canardo:/usr/local/src/git/linux$ git show --format=email 1b19e42952963ae2a09a655f487de15b7c81c5b7|./scripts/checkpatch.pl -
>   total: 0 errors, 0 warnings, 48 lines checked
>
>   Your patch has no obvious style problems and is ready for submission.

Yes, I found it. It was rather new patch adding more checks.
As a you pointed that can be workaround giving --format=email as a param 
for git show. But it is yet another "useless" param to remember...

So what is recommended way to ensure patch is correct currently?
a) before commit
b) after commit


commit 2011247550c1b903a9ecd68f6eb3e9e7b7b07f52
Author: Joe Perches <joe@perches.com>
Date:   Mon Jul 25 17:13:23 2011 -0700

     checkpatch: validate signature styles and To: and Cc: lines

     Signatures have many forms and can sometimes cause problems if not 
in the
     correct format when using git send-email or quilt.

     Try to verify the signature tags and email addresses to use the 
generally
     accepted "Signed-off-by: Full Name <email@domain.tld>" form.

     Original idea by Anish Kumar <anish198519851985@gmail.com>


regards
Antti


-- 
http://palosaari.fi/

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Joe Perches]

On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
> So what is recommended way to ensure patch is correct currently?
> a) before commit

Use checkpatch.

> b) after commit

Make the output of the commit log look like a patch.

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Antti Palosaari]

On 09/06/2011 06:15 PM, Joe Perches wrote:
> On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
>> So what is recommended way to ensure patch is correct currently?
>> a) before commit
>
> Use checkpatch.
>
>> b) after commit
>
> Make the output of the commit log look like a patch.

--format=email

But still that sounds annoying, GIT is our default tool for handling 
patches and all the other tools like checkpatch.pl should honour that 
without any tricks. Why you don't add some detection logic to 
checkpatch.pl or even some new switch like --git.

regards
Antti
-- 
http://palosaari.fi/

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Joe Perches]

On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote:
> On 09/06/2011 06:15 PM, Joe Perches wrote:
> > On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
> >> So what is recommended way to ensure patch is correct currently?
> >> a) before commit
> > Use checkpatch.
> >> b) after commit
> > Make the output of the commit log look like a patch.
> --format=email
> But still that sounds annoying, GIT is our default tool for handling 
> patches and all the other tools like checkpatch.pl should honour that 
> without any tricks. Why you don't add some detection logic to 
> checkpatch.pl or even some new switch like --git.

checkpatch is, as the name shows, for patches.

I think using checkpatch on commit logs is not
really useful.

If you're using checkpatch on commit logs, format
the commit log output appropriately or use
--ignore=BAD_SIGN_OFF or add that --ignore=
to a .checkpatch.conf if you really must.

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Antti Palosaari]

On 09/06/2011 07:10 PM, Joe Perches wrote:
> On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote:
>> On 09/06/2011 06:15 PM, Joe Perches wrote:
>>> On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
>>>> So what is recommended way to ensure patch is correct currently?
>>>> a) before commit
>>> Use checkpatch.
>>>> b) after commit
>>> Make the output of the commit log look like a patch.
>> --format=email
>> But still that sounds annoying, GIT is our default tool for handling
>> patches and all the other tools like checkpatch.pl should honour that
>> without any tricks. Why you don't add some detection logic to
>> checkpatch.pl or even some new switch like --git.
>
> checkpatch is, as the name shows, for patches.
>
> I think using checkpatch on commit logs is not
> really useful.

But that's what I have done every time I have added patches coming 
community. And also for my own patches. And when problem is found it is 
easy to git commit --amend and fix it. I think I am not the only 
maintainer who checks incoming patches like this way - you will got 
surely more feedback when that version of checkpatch will get more usage.

> If you're using checkpatch on commit logs, format
> the commit log output appropriately or use
> --ignore=BAD_SIGN_OFF or add that --ignore=
> to a .checkpatch.conf if you really must.

hmm, lets see. Maybe I will add --format=email as keyboard shortcut button.


Antti


-- 
http://palosaari.fi/

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

[Joe Perches]

On Tue, 2011-09-06 at 19:23 +0300, Antti Palosaari wrote:
> hmm, lets see. Maybe I will add --format=email as keyboard shortcut button.

or add 

[format]
	pretty = email

to your .gitconfig or create and use a
check_commitlog shell script or...