From: Antti Palosaari <crope@iki.fi>
To: Joe Perches <joe@perches.com>
Cc: "Bjørn Mork" <bjorn@mork.no>, linux-media@vger.kernel.org
Subject: Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:
Date: Tue, 06 Sep 2011 18:30:29 +0300 [thread overview]
Message-ID: <4E663C95.4080503@iki.fi> (raw)
In-Reply-To: <1315322125.30316.1.camel@Joe-Laptop>
On 09/06/2011 06:15 PM, Joe Perches wrote:
> On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
>> So what is recommended way to ensure patch is correct currently?
>> a) before commit
>
> Use checkpatch.
>
>> b) after commit
>
> Make the output of the commit log look like a patch.
--format=email
But still that sounds annoying, GIT is our default tool for handling
patches and all the other tools like checkpatch.pl should honour that
without any tricks. Why you don't add some detection logic to
checkpatch.pl or even some new switch like --git.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-09-06 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 22:39 checkpatch.pl WARNING: Do not use whitespace before Signed-off-by: Antti Palosaari
2011-09-06 7:50 ` Bjørn Mork
2011-09-06 14:41 ` Antti Palosaari
2011-09-06 15:15 ` Joe Perches
2011-09-06 15:30 ` Antti Palosaari [this message]
2011-09-06 16:10 ` Joe Perches
2011-09-06 16:23 ` Antti Palosaari
2011-09-06 16:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E663C95.4080503@iki.fi \
--to=crope@iki.fi \
--cc=bjorn@mork.no \
--cc=joe@perches.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox