Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

[Antti Palosaari <crope@iki.fi>]

On 08/01/2011 05:24 AM, Mauro Carvalho Chehab wrote:
> Em 31-07-2011 22:22, Antti Palosaari escreveu:
>> On 08/01/2011 03:46 AM, Mauro Carvalho Chehab wrote:
>>> One bad thing I noticed with the API is that it calls adap->props.frontend_attach(adap)
>>> several times, instead of just one, without even passing an argument for the driver to
>>> know that it was called twice.
>>>
>>> IMO, there are two ways of doing the attach:
>>>
>>> 1) call it only once, and, inside the driver, it will loop to add the other FE's;
>>> 2) add a parameter, at the call, to say what FE needs to be initialized.
>>>
>>> I think (1) is preferred, as it is more flexible, allowing the driver to test for
>>> several types of frontends.

I am planning to change DVB USB MFE call .frontend_attach() only once. 
Is there any comments about that?

Currently there is anysee, ttusb2 and cx88 drivers which uses MFE and 
change is needed ASAP before more MFE devices are coming.

Also .num_frontends can be removed after that, since DVB USB will just 
loop through 0 to MAX FEs and register all FEs found (fe pointer !NULL).

CURRENTLY:
==========
.frontend_attach()
	if (adap->fe_adap[0].fe == NULL)
		adap->fe_adap[0].fe = dvb_attach(DVB-T)
	else if (adap->fe_adap[1].fe == NULL)
		adap->fe_adap[1].fe = dvb_attach(DVB-C)
	else if (adap->fe_adap[2].fe == NULL)
		adap->fe_adap[2].fe = dvb_attach(DVB-S)

PLANNED:
========
.frontend_attach()
	adap->fe_adap[0].fe = dvb_attach(DVB-T)
	adap->fe_adap[1].fe = dvb_attach(DVB-C)
	adap->fe_adap[2].fe = dvb_attach(DVB-S)


regards
Antti
-- 
http://palosaari.fi/