Re: [PATCH 2/3] dvb-usb: multi-frontend support (MFE)

[Antti Palosaari <crope@iki.fi>]

On 09/07/2011 09:36 PM, Michael Krufky wrote:
> On Wed, Sep 7, 2011 at 2:20 PM, Antti Palosaari<crope@iki.fi>  wrote:

>> Yes, I now saw when looked latest anysee driver that you moved
>> .streaming_ctrl(), .frontend_attach() and .tuner_attach() to frontend
>> property. OK, it is not then relevant anymore to change register all as
>> once.
>>
>> What is size_of_priv used?
>
> size_of_priv is a signal to the dvb-usb framework to allocate memory
> of size, size_of_priv to track device state at a given context.  If
> you look in dvb-usb.h, there was always a size_of_priv / void *priv at
> the dvb_usb_device context level, and there was always a size_of_priv
> / void *priv at the dvb_usb_adapter context level.   After my MFE
> patch, there is now a size_of_priv / void *priv at the
> dvb_usb_fe_adapter context level.  This private state structure is
> used to track state at the context of each dvb_usb_fe_adap, to manage
> the environment needed to switch between the various attached
> frontends.  You may take a look in mxl111sf.c to see how this is used
> (ie, struct mxl111sf_adap_state *adap_state =
> adap->fe_adap[fe->id].priv;)
>
> If size_of_priv is left undefined, it is initialized to 0, and the
> void *priv pointer remains null.

I marvel at there was 3 states, one for device, one for each adapter and 
now even one for each frontend. Surely enough, generally only device 
state is used. And your new driver seems to even use that new FE priv added.

regards
Antti


-- 
http://palosaari.fi/