Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Antti Palosaari]

This patch seems to break all DVB USB devices we have. Michael, could 
you check and fix it asap.

On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
> This is an automatic generated email to let you know that the following patch were queued at the
> http://git.linuxtv.org/media_tree.git tree:
>
> Subject: [media] dvb-usb: refactor MFE code for individual streaming config per frontend
> Author:  Michael Krufky<mkrufky@kernellabs.com>
> Date:    Tue Sep 6 09:31:57 2011 -0300
>
> refactor MFE code to allow for individual streaming configuration
> for each frontend
>
> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
> Reviewed-by: Antti Palosaari<crope@iki.fi>
> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>

>   drivers/media/dvb/dvb-usb/dvb-usb-dvb.c     |  141 ++++++-----

dvb_usb_ctrl_feed()
	if ((adap->feedcount == onoff) && (!onoff))
		adap->active_fe = -1;



> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
> <diff discarded since it is too big>


regards
Antti

-- 
http://palosaari.fi/

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Antti Palosaari]

This error is shown by VLC when channel changed:

[0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid 
argument)
[0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
[0x7f1bbc32f910] main stream error: cannot pre fill buffer


but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.

Antti


On 09/08/2011 12:18 AM, Antti Palosaari wrote:
> This patch seems to break all DVB USB devices we have. Michael, could
> you check and fix it asap.
>
> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>> This is an automatic generated email to let you know that the
>> following patch were queued at the
>> http://git.linuxtv.org/media_tree.git tree:
>>
>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>> config per frontend
>> Author: Michael Krufky<mkrufky@kernellabs.com>
>> Date: Tue Sep 6 09:31:57 2011 -0300
>>
>> refactor MFE code to allow for individual streaming configuration
>> for each frontend
>>
>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>
> dvb_usb_ctrl_feed()
> if ((adap->feedcount == onoff) && (!onoff))
> adap->active_fe = -1;
>
>
>
>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>
>> <diff discarded since it is too big>
>
>
> regards
> Antti
>


-- 
http://palosaari.fi/

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Michael Krufky]

> On 09/08/2011 12:18 AM, Antti Palosaari wrote:
>>
>> This patch seems to break all DVB USB devices we have. Michael, could
>> you check and fix it asap.
>>
>> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>>>
>>> This is an automatic generated email to let you know that the
>>> following patch were queued at the
>>> http://git.linuxtv.org/media_tree.git tree:
>>>
>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>>> config per frontend
>>> Author: Michael Krufky<mkrufky@kernellabs.com>
>>> Date: Tue Sep 6 09:31:57 2011 -0300
>>>
>>> refactor MFE code to allow for individual streaming configuration
>>> for each frontend
>>>
>>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>
>>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>>
>> dvb_usb_ctrl_feed()
>> if ((adap->feedcount == onoff) && (!onoff))
>> adap->active_fe = -1;
>>
>>
>>
>>>
>>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>>
>>> <diff discarded since it is too big>
>>
>>

On Wed, Sep 7, 2011 at 5:21 PM, Antti Palosaari <crope@iki.fi> wrote:
> This error is shown by VLC when channel changed:
>
> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid
> argument)
> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
> [0x7f1bbc32f910] main stream error: cannot pre fill buffer
>
>
> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.
>
> Antti
>
>


I will take a look at this tonight and give it a test with vlc.
Thanks for reporting the problem.

Regards,

Mike

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Michael Krufky]

On Wed, Sep 7, 2011 at 5:35 PM, Michael Krufky <mkrufky@kernellabs.com> wrote:
>> On 09/08/2011 12:18 AM, Antti Palosaari wrote:
>>>
>>> This patch seems to break all DVB USB devices we have. Michael, could
>>> you check and fix it asap.
>>>
>>> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>>>>
>>>> This is an automatic generated email to let you know that the
>>>> following patch were queued at the
>>>> http://git.linuxtv.org/media_tree.git tree:
>>>>
>>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>>>> config per frontend
>>>> Author: Michael Krufky<mkrufky@kernellabs.com>
>>>> Date: Tue Sep 6 09:31:57 2011 -0300
>>>>
>>>> refactor MFE code to allow for individual streaming configuration
>>>> for each frontend
>>>>
>>>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>>>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>>>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>>
>>>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>>>
>>> dvb_usb_ctrl_feed()
>>> if ((adap->feedcount == onoff) && (!onoff))
>>> adap->active_fe = -1;
>>>
>>>
>>>
>>>>
>>>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>>>
>>>> <diff discarded since it is too big>
>>>
>>>
>
> On Wed, Sep 7, 2011 at 5:21 PM, Antti Palosaari <crope@iki.fi> wrote:
>> This error is shown by VLC when channel changed:
>>
>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid
>> argument)
>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
>> [0x7f1bbc32f910] main stream error: cannot pre fill buffer
>>
>>
>> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.
>>
>> Antti
>>
>>
>
>
> I will take a look at this tonight and give it a test with vlc.
> Thanks for reporting the problem.


Antti,

Just to be sure -- which device driver did you use for your testing,
and are you using the exact code in Mauro's for_v3.2 branch, or
modified code?

Thanks,

Mike Krufky

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Antti Palosaari]

On 09/08/2011 12:39 AM, Michael Krufky wrote:
> On Wed, Sep 7, 2011 at 5:35 PM, Michael Krufky<mkrufky@kernellabs.com>  wrote:
>>> On 09/08/2011 12:18 AM, Antti Palosaari wrote:
>>>>
>>>> This patch seems to break all DVB USB devices we have. Michael, could
>>>> you check and fix it asap.
>>>>
>>>> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>>>>>
>>>>> This is an automatic generated email to let you know that the
>>>>> following patch were queued at the
>>>>> http://git.linuxtv.org/media_tree.git tree:
>>>>>
>>>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>>>>> config per frontend
>>>>> Author: Michael Krufky<mkrufky@kernellabs.com>
>>>>> Date: Tue Sep 6 09:31:57 2011 -0300
>>>>>
>>>>> refactor MFE code to allow for individual streaming configuration
>>>>> for each frontend
>>>>>
>>>>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>>>>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>>>>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>>>
>>>>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>>>>
>>>> dvb_usb_ctrl_feed()
>>>> if ((adap->feedcount == onoff)&&  (!onoff))
>>>> adap->active_fe = -1;
>>>>
>>>>
>>>>
>>>>>
>>>>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>>>>
>>>>> <diff discarded since it is too big>
>>>>
>>>>
>>
>> On Wed, Sep 7, 2011 at 5:21 PM, Antti Palosaari<crope@iki.fi>  wrote:
>>> This error is shown by VLC when channel changed:
>>>
>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid
>>> argument)
>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
>>> [0x7f1bbc32f910] main stream error: cannot pre fill buffer
>>>
>>>
>>> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.
>>>
>>> Antti
>>>
>>>
>>
>>
>> I will take a look at this tonight and give it a test with vlc.
>> Thanks for reporting the problem.
>
>
> Antti,
>
> Just to be sure -- which device driver did you use for your testing,
> and are you using the exact code in Mauro's for_v3.2 branch, or
> modified code?

Few hours since updated linux-media remote.
remotes/media/staging/for_v3.2

last commit:

commit d4d4e3c97211f20d4fde5d82878561adaa42b578
Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date:   Thu Jul 7 12:13:25 2011 -0300

     [media] s5p-csis: Rework the system suspend/resume helpers

     Do not resume the device during system resume if it was idle
     before system suspend, as this causes resume from suspend
     to RAM failures on Exynos4. For this purpose runtime PM and
     system sleep helpers are separated.

     Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
     Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

I tested using one Anysee DVB-C model and one AF9015 DVB-T device.

Commenting out that
 >>>> if ((adap->feedcount == onoff)&&  (!onoff))
 >>>> adap->active_fe = -1;

resolves problem.

regards
Antti
-- 
http://palosaari.fi/

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Michael Krufky]

On Wed, Sep 7, 2011 at 5:45 PM, Antti Palosaari <crope@iki.fi> wrote:
> On 09/08/2011 12:39 AM, Michael Krufky wrote:
>>
>> On Wed, Sep 7, 2011 at 5:35 PM, Michael Krufky<mkrufky@kernellabs.com>
>>  wrote:
>>>>
>>>> On 09/08/2011 12:18 AM, Antti Palosaari wrote:
>>>>>
>>>>> This patch seems to break all DVB USB devices we have. Michael, could
>>>>> you check and fix it asap.
>>>>>
>>>>> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>>>>>>
>>>>>> This is an automatic generated email to let you know that the
>>>>>> following patch were queued at the
>>>>>> http://git.linuxtv.org/media_tree.git tree:
>>>>>>
>>>>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>>>>>> config per frontend
>>>>>> Author: Michael Krufky<mkrufky@kernellabs.com>
>>>>>> Date: Tue Sep 6 09:31:57 2011 -0300
>>>>>>
>>>>>> refactor MFE code to allow for individual streaming configuration
>>>>>> for each frontend
>>>>>>
>>>>>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>>>>>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>>>>>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>>>>
>>>>>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>>>>>
>>>>> dvb_usb_ctrl_feed()
>>>>> if ((adap->feedcount == onoff)&&  (!onoff))
>>>>> adap->active_fe = -1;
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>>>>>
>>>>>> <diff discarded since it is too big>
>>>>>
>>>>>
>>>
>>> On Wed, Sep 7, 2011 at 5:21 PM, Antti Palosaari<crope@iki.fi>  wrote:
>>>>
>>>> This error is shown by VLC when channel changed:
>>>>
>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid
>>>> argument)
>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
>>>> [0x7f1bbc32f910] main stream error: cannot pre fill buffer
>>>>
>>>>
>>>> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.
>>>>
>>>> Antti
>>>>
>>>>
>>>
>>>
>>> I will take a look at this tonight and give it a test with vlc.
>>> Thanks for reporting the problem.
>>
>>
>> Antti,
>>
>> Just to be sure -- which device driver did you use for your testing,
>> and are you using the exact code in Mauro's for_v3.2 branch, or
>> modified code?
>
> Few hours since updated linux-media remote.
> remotes/media/staging/for_v3.2
>
> last commit:
>
> commit d4d4e3c97211f20d4fde5d82878561adaa42b578
> Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Date:   Thu Jul 7 12:13:25 2011 -0300
>
>    [media] s5p-csis: Rework the system suspend/resume helpers
>
>    Do not resume the device during system resume if it was idle
>    before system suspend, as this causes resume from suspend
>    to RAM failures on Exynos4. For this purpose runtime PM and
>    system sleep helpers are separated.
>
>    Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>    Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> I tested using one Anysee DVB-C model and one AF9015 DVB-T device.
>
> Commenting out that
>>>>> if ((adap->feedcount == onoff)&&  (!onoff))
>>>>> adap->active_fe = -1;
>
> resolves problem.

OK...  I think it's safe to remove that code.  The only time that
"adap->active_fe" should really be set to -1 is at startup, before
*any* frontend is used.  Does removal of those two lines fix it for
you completely?

-Mike

Re: [git:v4l-dvb/for_v3.2] [media] dvb-usb: refactor MFE code for individual streaming config per frontend

[Michael Krufky]

On Wed, Sep 7, 2011 at 5:52 PM, Michael Krufky <mkrufky@kernellabs.com> wrote:
> On Wed, Sep 7, 2011 at 5:45 PM, Antti Palosaari <crope@iki.fi> wrote:
>> On 09/08/2011 12:39 AM, Michael Krufky wrote:
>>>
>>> On Wed, Sep 7, 2011 at 5:35 PM, Michael Krufky<mkrufky@kernellabs.com>
>>>  wrote:
>>>>>
>>>>> On 09/08/2011 12:18 AM, Antti Palosaari wrote:
>>>>>>
>>>>>> This patch seems to break all DVB USB devices we have. Michael, could
>>>>>> you check and fix it asap.
>>>>>>
>>>>>> On 09/06/2011 08:21 PM, Mauro Carvalho Chehab wrote:
>>>>>>>
>>>>>>> This is an automatic generated email to let you know that the
>>>>>>> following patch were queued at the
>>>>>>> http://git.linuxtv.org/media_tree.git tree:
>>>>>>>
>>>>>>> Subject: [media] dvb-usb: refactor MFE code for individual streaming
>>>>>>> config per frontend
>>>>>>> Author: Michael Krufky<mkrufky@kernellabs.com>
>>>>>>> Date: Tue Sep 6 09:31:57 2011 -0300
>>>>>>>
>>>>>>> refactor MFE code to allow for individual streaming configuration
>>>>>>> for each frontend
>>>>>>>
>>>>>>> Signed-off-by: Michael Krufky<mkrufky@kernellabs.com>
>>>>>>> Reviewed-by: Antti Palosaari<crope@iki.fi>
>>>>>>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>>>>>>
>>>>>>> drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 141 ++++++-----
>>>>>>
>>>>>> dvb_usb_ctrl_feed()
>>>>>> if ((adap->feedcount == onoff)&&  (!onoff))
>>>>>> adap->active_fe = -1;
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=77eed219fed5a913f59329cc846420fdeab0150f
>>>>>>>
>>>>>>> <diff discarded since it is too big>
>>>>>>
>>>>>>
>>>>
>>>> On Wed, Sep 7, 2011 at 5:21 PM, Antti Palosaari<crope@iki.fi>  wrote:
>>>>>
>>>>> This error is shown by VLC when channel changed:
>>>>>
>>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter: failed with -1 (Invalid
>>>>> argument)
>>>>> [0x7f1bbc000cd0] dvb access error: DMXSetFilter failed
>>>>> [0x7f1bbc32f910] main stream error: cannot pre fill buffer
>>>>>
>>>>>
>>>>> but it seems to be related dvb_usb_ctrl_feed() I pointed earlier mail.
>>>>>
>>>>> Antti
>>>>>
>>>>>
>>>>
>>>>
>>>> I will take a look at this tonight and give it a test with vlc.
>>>> Thanks for reporting the problem.
>>>
>>>
>>> Antti,
>>>
>>> Just to be sure -- which device driver did you use for your testing,
>>> and are you using the exact code in Mauro's for_v3.2 branch, or
>>> modified code?
>>
>> Few hours since updated linux-media remote.
>> remotes/media/staging/for_v3.2
>>
>> last commit:
>>
>> commit d4d4e3c97211f20d4fde5d82878561adaa42b578
>> Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Date:   Thu Jul 7 12:13:25 2011 -0300
>>
>>    [media] s5p-csis: Rework the system suspend/resume helpers
>>
>>    Do not resume the device during system resume if it was idle
>>    before system suspend, as this causes resume from suspend
>>    to RAM failures on Exynos4. For this purpose runtime PM and
>>    system sleep helpers are separated.
>>
>>    Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>    Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> I tested using one Anysee DVB-C model and one AF9015 DVB-T device.
>>
>> Commenting out that
>>>>>> if ((adap->feedcount == onoff)&&  (!onoff))
>>>>>> adap->active_fe = -1;
>>
>> resolves problem.
>
> OK...  I think it's safe to remove that code.  The only time that
> "adap->active_fe" should really be set to -1 is at startup, before
> *any* frontend is used.  Does removal of those two lines fix it for
> you completely?

BTW, I understand the cause of this now -- this error case occurs when
the application stops streaming but leaves the frontend open.  (for
instance, to change the channel)  We only want to set (adap->active_fe
= -1) if ( ((adap->feedcount == onoff)&&  (!onoff)) AND ALSO only if
the file handle gets closed.

It's safe to just disable those lines for now.

Regards,

Mike Krufky