From: Antti Palosaari <crope@iki.fi>
To: Chris Rankin <rankincj@yahoo.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Devin Heitmueller <dheitmueller@kernellabs.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] EM28xx - fix deadlock when unplugging and replugging a DVB adapter
Date: Tue, 13 Sep 2011 23:04:06 +0300 [thread overview]
Message-ID: <4E6FB736.4080202@iki.fi> (raw)
In-Reply-To: <4E50FAC7.6080807@yahoo.com>
On 08/21/2011 03:32 PM, Chris Rankin wrote:
> It occurred to me this morning that since we're no longer supposed to be
> holding the device lock when taking the device list lock, then the
> em28xx_usb_disconnect() function needs changing too.
>
> Signed-off-by: Chris Rankin <rankincj@yahoo.com>
I ran that also when re-plugging both PCTV 290e and 460e as today
LinuxTV 3.2 tree. Seems like this patch is still missing and maybe some
more.
git log drivers/media/video/em28xx/ |grep -A3 "Author: Chris Rankin"
Author: Chris Rankin <rankincj@yahoo.com>
Date: Tue Sep 13 12:23:39 2011 +0300
em28xx: ERROR: "em28xx_add_into_devlist"
[drivers/media/video/em28xx/em28xx.ko] undefined!
--
Author: Chris Rankin <rankincj@yahoo.com>
Date: Sat Aug 20 16:01:26 2011 -0300
[media] em28xx: don't sleep on disconnect
--
Author: Chris Rankin <rankincj@yahoo.com>
Date: Sat Aug 20 08:31:05 2011 -0300
[media] em28xx: move printk lines outside mutex lock
--
Author: Chris Rankin <rankincj@yahoo.com>
Date: Sat Aug 20 08:28:17 2011 -0300
[media] em28xx: clean up resources should init fail
--
Author: Chris Rankin <rankincj@yahoo.com>
Date: Sat Aug 20 08:21:03 2011 -0300
[media] em28xx: use atomic bit operations for devices-in-use mask
--
Author: Chris Rankin <rankincj@yahoo.com>
Date: Sat Aug 20 08:08:34 2011 -0300
[media] em28xx: pass correct buffer size to snprintf
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-09-13 20:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 17:52 [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e Chris Rankin
2011-08-18 18:43 ` Devin Heitmueller
2011-08-18 18:44 ` Devin Heitmueller
2011-08-18 21:34 ` Chris Rankin
2011-08-18 22:11 ` Chris Rankin
2011-08-19 5:53 ` Mauro Carvalho Chehab
2011-08-20 11:08 ` [PATCH 1/6 ] EM28xx - pass correct buffer size to snprintf Chris Rankin
2011-08-20 11:14 ` [PATCH 2/6] Fix memory leak on disconnect or error Chris Rankin
2011-08-20 11:21 ` [PATCH 3/6] EM28xx - use atomic bit operations for devices-in-use mask Chris Rankin
2011-08-20 11:28 ` [PATCH 4/6] EM28xx - clean up resources should init fail Chris Rankin
2011-08-20 11:31 ` [PATCH 5/6] EM28xx - move printk lines outside mutex lock Chris Rankin
2011-08-20 11:37 ` [PATCH 6/6] EM28xx - don't sleep on disconnect Chris Rankin
2011-08-20 12:17 ` Mauro Carvalho Chehab
2011-08-20 13:46 ` Chris Rankin
2011-08-20 14:20 ` Mauro Carvalho Chehab
2011-08-20 19:01 ` Chris Rankin
2011-08-20 11:42 ` [PATCH 1/2] EM28xx - fix race " Chris Rankin
2011-08-20 12:36 ` Sylwester Nawrocki
2011-08-20 11:46 ` [PATCH 2/2] EM28xx - fix deadlock when unplugging and replugging a DVB adapter Chris Rankin
2011-08-20 12:34 ` Mauro Carvalho Chehab
2011-08-20 14:40 ` Chris Rankin
2011-08-20 15:02 ` Mauro Carvalho Chehab
2011-08-20 22:38 ` [PATCH 1/1] " Chris Rankin
2011-08-21 12:32 ` Chris Rankin
2011-09-13 20:04 ` Antti Palosaari [this message]
2011-09-13 20:47 ` Chris Rankin
2011-08-18 22:28 ` [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e Chris Rankin
2011-08-18 23:45 ` Chris Rankin
2011-08-19 0:12 ` Chris Rankin
2011-08-18 19:56 ` Chris Rankin
2011-08-19 1:01 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6FB736.4080202@iki.fi \
--to=crope@iki.fi \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox