From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver
Date: Thu, 15 Sep 2011 10:49:10 +0200 [thread overview]
Message-ID: <4E71BC06.5020401@samsung.com> (raw)
In-Reply-To: <CAHG8p1AM9HxRSfEOEc8_cuvSkRO8LvUw0DCAfcK+_SHD8yr=cg@mail.gmail.com>
On 09/15/2011 08:37 AM, Scott Jiang wrote:
>>
>>> +
>>> +#define CAPTURE_DRV_NAME "bfin_capture"
>>> +#define BCAP_MIN_NUM_BUF 2
>>> +
>>> +struct bcap_format {
>>> + u8 *desc;
>>> + u32 pixelformat;
>>> + enum v4l2_mbus_pixelcode mbus_code;
>>> + int bpp; /* bytes per pixel */
>>
>> Don't you think you might have to process 12 bpp formats at some point,
>> like YUV 4:2:0, or NV12? Maybe better calculate in bits from the beginning?
>>
> I have a question here. How to calculate bytesperline for planar format?
> According to v4l2 specification width, height and bytesperline apply
> to largest plane.
> Does it mean bytesperline equal to Y plane distance between two line?
For planar formats - I think so.
> And so you can't use bytesperline x height to calculate sizeimage?
No, you can't. Please see this thread:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg28957.html
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
next prev parent reply other threads:[~2011-09-15 8:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 18:34 [PATCH 1/4] v4l2: add vb2_get_unmapped_area in vb2 core Scott Jiang
2011-09-13 8:17 ` Guennadi Liakhovetski
2011-09-13 8:36 ` Scott Jiang
2011-09-13 18:34 ` [PATCH 2/4] v4l2: add adv7183 decoder driver Scott Jiang
2011-09-14 3:05 ` [uclinux-dist-devel] " Mike Frysinger
2011-09-13 18:34 ` [PATCH 3/4] v4l2: add vs6624 sensor driver Scott Jiang
2011-09-13 7:42 ` Guennadi Liakhovetski
2011-09-13 8:20 ` Scott Jiang
2011-09-13 8:22 ` Guennadi Liakhovetski
2011-09-14 3:28 ` [uclinux-dist-devel] " Mike Frysinger
2011-09-14 7:28 ` Scott Jiang
2011-09-18 2:52 ` Mike Frysinger
2011-09-13 18:34 ` [PATCH 4/4] v4l2: add blackfin capture bridge driver Scott Jiang
2011-09-13 8:11 ` Guennadi Liakhovetski
2011-09-13 9:56 ` Scott Jiang
2011-09-13 11:15 ` Guennadi Liakhovetski
2011-09-14 6:14 ` Scott Jiang
2011-09-16 8:11 ` Scott Jiang
2011-09-16 8:46 ` Guennadi Liakhovetski
2011-09-15 6:37 ` Scott Jiang
2011-09-15 8:49 ` Sylwester Nawrocki [this message]
2011-09-13 21:19 ` Sylwester Nawrocki
2011-09-14 7:10 ` Scott Jiang
2011-09-14 14:30 ` Sylwester Nawrocki
2011-09-15 2:40 ` Scott Jiang
2011-09-15 6:35 ` Guennadi Liakhovetski
2011-09-15 6:48 ` Scott Jiang
2011-09-15 7:14 ` Guennadi Liakhovetski
2011-09-15 7:26 ` Scott Jiang
2011-09-15 7:32 ` Guennadi Liakhovetski
2011-09-15 21:17 ` Sylwester Nawrocki
2011-09-16 2:34 ` Scott Jiang
2011-09-16 6:48 ` Guennadi Liakhovetski
2011-09-26 14:25 ` Hans Verkuil
2011-10-01 10:03 ` Sylwester Nawrocki
2011-09-14 3:19 ` [uclinux-dist-devel] " Mike Frysinger
2011-09-14 7:16 ` Scott Jiang
2011-09-14 7:22 ` Guennadi Liakhovetski
2011-09-17 20:54 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E71BC06.5020401@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox