From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, kyungmin.park@samsung.com,
m.szyprowski@samsung.com,
Kyungmin Park <kyungin.park@samsung.com>
Subject: Re: [PATCH 1/3] sr030pc30: Remove empty s_stream op
Date: Wed, 21 Sep 2011 17:31:30 +0200 [thread overview]
Message-ID: <4E7A0352.104@samsung.com> (raw)
In-Reply-To: <4E7A014F.5040602@redhat.com>
On 09/21/2011 05:22 PM, Mauro Carvalho Chehab wrote:
> Em 19-01-2011 23:44, Sylwester Nawrocki escreveu:
>> s_stream does nothing in current form so remove it.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungin.park@samsung.com>
>> ---
>> drivers/media/video/sr030pc30.c | 6 ------
>> 1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/media/video/sr030pc30.c b/drivers/media/video/sr030pc30.c
>> index c901721..e1eced1 100644
>> --- a/drivers/media/video/sr030pc30.c
>> +++ b/drivers/media/video/sr030pc30.c
>> @@ -714,11 +714,6 @@ static int sr030pc30_base_config(struct v4l2_subdev *sd)
>> return ret;
>> }
>>
>> -static int sr030pc30_s_stream(struct v4l2_subdev *sd, int enable)
>> -{
>> - return 0;
>> -}
>> -
>> static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
>> {
>> struct i2c_client *client = v4l2_get_subdevdata(sd);
>> @@ -761,7 +756,6 @@ static const struct v4l2_subdev_core_ops sr030pc30_core_ops = {
>> };
>>
>> static const struct v4l2_subdev_video_ops sr030pc30_video_ops = {
>> - .s_stream = sr030pc30_s_stream,
>> .g_mbus_fmt = sr030pc30_g_fmt,
>> .s_mbus_fmt = sr030pc30_s_fmt,
>> .try_mbus_fmt = sr030pc30_try_fmt,
>
> Hmm...
> this patch[1] were never merged. It seems a cleanup, though.
>
> Care to review it?
Indeed, it is still worth to apply. There was some ongoing work
at the control framework and other patches form this series need some
more modifications. But this one alone can be merged.
>
> Thanks!
> Mauro
>
> [1] http://patchwork.linuxtv.org/patch/5631/
>
>
Thank you,
--
Sylwester Nawrocki
Samsung Poland R&D Center
next prev parent reply other threads:[~2011-09-21 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 1:43 [PATCH 0/3] Convert SR030PC30 driver to use the control framework and the regulator API Sylwester Nawrocki
2011-01-20 1:44 ` [PATCH 1/3] sr030pc30: Remove empty s_stream op Sylwester Nawrocki
2011-09-21 15:22 ` Mauro Carvalho Chehab
2011-09-21 15:31 ` Sylwester Nawrocki [this message]
2011-01-20 1:44 ` [PATCH 2/3] sr030pc30: Use the control framework Sylwester Nawrocki
2011-01-20 19:09 ` Hans Verkuil
2011-01-22 16:28 ` Sylwester Nawrocki
2011-01-23 11:21 ` Sylwester Nawrocki
2011-01-20 1:44 ` [PATCH 3/3] sr030pc30: Add regulator framework support Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7A0352.104@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kyungin.park@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).