public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Simon Farnsworth <simon.farnsworth@onelan.com>
Cc: LMML <linux-media@vger.kernel.org>,
	Michael Krufky <mkrufky@kernellabs.com>,
	devin heitmueller <dheitmueller@kernellabs.com>
Subject: Re: Problems tuning PAL-D with a Hauppauge HVR-1110 (TDA18271 tuner) - workaround hack included
Date: Fri, 30 Sep 2011 07:48:20 -0300	[thread overview]
Message-ID: <4E859E74.7080900@infradead.org> (raw)
In-Reply-To: <201109281350.52099.simon.farnsworth@onelan.com>

Em 28-09-2011 09:50, Simon Farnsworth escreveu:
> (note - the CC list is everyone over 50% certainty from get_maintainer.pl)
> 
> I'm having problems getting a Hauppauge HVR-1110 card to successfully
> tune PAL-D at 85.250 MHz vision frequency; by experimentation, I've
> determined that the tda18271 is tuning to a frequency 1.25 MHz lower
> than the vision frequency I've requested, so the following workaround
> "fixes" it for me.
> 
> diff --git a/drivers/media/common/tuners/tda18271-fe.c 
> b/drivers/media/common/tuners/tda18271-fe.c
> index 63cc400..1a94e1a 100644
> --- a/drivers/media/common/tuners/tda18271-fe.c
> +++ b/drivers/media/common/tuners/tda18271-fe.c
> @@ -1031,6 +1031,7 @@ static int tda18271_set_analog_params(struct 
> dvb_frontend *fe,
>  		mode = "I";
>  	} else if (params->std & V4L2_STD_DK) {
>  		map = &std_map->atv_dk;
> +                freq += 1250000;
>  		mode = "DK";
>  	} else if (params->std & V4L2_STD_SECAM_L) {
>  		map = &std_map->atv_l;

If I am to fix this bug, instead of a hack like that, it seems to be better
to split the .atv_dk line at the struct tda18271_std_map maps on
drivers/media/common/tuners/tda18271-maps.c.

Looking at the datasheet, on page 43, available at:
	http://www.nxp.com/documents/data_sheet/TDA18271HD.pdf

The offset values for IF seem ok, but maybe your device is using some variant
of this chip that requires a different maps table.

> 
> I've checked with a signal analyser, and confirmed that my signal
> generator is getting the spectrum right - I am seeing vision peaking
> at 85.25 MHz, with one sideband going down to 84.5 MHz, and the other
> going up to 90.5MHz. I also see an audio carrier at 91.75 MHz.
> 
> I'm going to run with this hack in place, but I'd appreciate it if
> someone who knew more about the TDA18271 looked at this, and either
> gave me a proper fix for testing, or confirmed that what I'm doing is
> right.
> --
> Simon Farnsworth
> Software Engineer
> ONELAN Limited
> http://www.onelan.com/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  parent reply	other threads:[~2011-09-30 10:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 12:50 Problems tuning PAL-D with a Hauppauge HVR-1110 (TDA18271 tuner) - workaround hack included Simon Farnsworth
2011-09-28 14:20 ` Devin Heitmueller
2011-09-28 14:27   ` Simon Farnsworth
2011-09-30 10:48 ` Mauro Carvalho Chehab [this message]
2011-09-30 11:03   ` Simon Farnsworth
2011-09-30 11:59     ` Mauro Carvalho Chehab
2011-09-30 14:43       ` Devin Heitmueller
2011-09-30 11:11   ` Simon Farnsworth
2011-09-30 13:35     ` Mauro Carvalho Chehab
2011-09-30 18:05 ` Malcolm Priestley
2011-10-03  8:56   ` Simon Farnsworth
2011-09-30 19:37 ` Steven Toth
2011-09-30 21:25   ` Andy Walls
2011-10-03  8:57     ` Simon Farnsworth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E859E74.7080900@infradead.org \
    --to=mchehab@infradead.org \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mkrufky@kernellabs.com \
    --cc=simon.farnsworth@onelan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox