From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from hermes.mlbassoc.com ([64.234.241.98]:43072 "EHLO mail.chez-thomas.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178Ab1JCKd3 (ORCPT ); Mon, 3 Oct 2011 06:33:29 -0400 Message-ID: <4E898F76.5070604@mlbassoc.com> Date: Mon, 03 Oct 2011 04:33:26 -0600 From: Gary Thomas MIME-Version: 1.0 To: Enrico CC: Javier Martinez Canillas , linux-media@vger.kernel.org Subject: Re: [PATCH 0/3] [media] tvp5150: Migrate to media-controller framework and add video format detection References: <1317429231-11359-1-git-send-email-martinez.javier@gmail.com> <4E8716D1.9010104@mlbassoc.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 2011-10-01 10:39, Enrico wrote: > On Sat, Oct 1, 2011 at 5:55 PM, Javier Martinez Canillas > wrote: >> We hack a few bits of the ISP CCDC driver to support ITU-R BT656 >> interlaced data with embedded syncs video format and ported the >> tvp5150 driver to the MCF so it can be detected as a sub-device and be >> part of the OMAP ISP image processing pipeline (as a source pad). > > That was already posted on the list [1], there was some discussion but > i don't know what's the status/plan to get it into mainline. > > And, as you can see in [2], don't expect many comments :D > > [1]: http://www.spinics.net/lists/linux-media/msg37710.html > [2]: http://www.spinics.net/lists/linux-media/msg37116.html > > >>> Even if it does detect the signal shape (NTSC, PAL), doesn't one still need >>> to [externally] configure the pads for this shape? >>> >> >> Yes, that is why I wanted to do the auto-detection for the tvp5151, so >> we only have to manually configure the ISP components (or any other >> hardware video processing pipeline entities, sorry for my >> OMAP-specific comments). > > Laurent was not very happy [3] about changing video formats out of the > driver control, so this should be discussed more. > > [3]: http://www.spinics.net/lists/linux-omap/msg56983.html > > >> I didn't know that the physical connection affected the video output >> format, I thought that it was only a physical medium to carry the same >> information, sorry if my comments are silly but I'm really newbie with >> video in general. > > I think you got it right, i haven't tested it but the output format > shouldn't be affected by the video source( if it stays pal/ntsc of > course). Maybe you will get only a different "active" video area so > only cropping will be affected. It's not so much the video output [shape], rather that the input source can be selected and there does not seem to be a way to do that currently using the MC framework. I was thinking perhaps to have the driver have 3 different output pads and depending on which one you choose to link up tells the driver how to configure the input. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------