From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:36411 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933898Ab1JEGTO (ORCPT ); Wed, 5 Oct 2011 02:19:14 -0400 Message-ID: <4E8BF6DE.1010105@iki.fi> Date: Wed, 05 Oct 2011 09:19:10 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Oliver Neukum CC: Greg KH , linux-serial@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, =?ISO-8859-1?Q?Bj=F8rn_Mork?= , James Courtier-Dutton , HoP , =?ISO-8859-1?Q?Istv=E1n_V=E1radi?= Subject: Re: serial device name for smart card reader that is integrated to Anysee DVB USB device References: <4E8B7901.2050700@iki.fi> <20111005045917.GB4700@kroah.com> <4E8BF21B.4010907@iki.fi> <201110050815.17949.oneukum@suse.de> In-Reply-To: <201110050815.17949.oneukum@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 10/05/2011 09:15 AM, Oliver Neukum wrote: > Am Mittwoch, 5. Oktober 2011, 07:58:51 schrieb Antti Palosaari: >> On 10/05/2011 07:59 AM, Greg KH wrote: > >>> Why not just use the usb-serial core and then you get a ttyUSB* device >>> node "for free"? It also should provide a lot of the basic tty >>> infrastructure and ring buffer logic all ready to use. >> >> Since I don't see how I can access same platform data from DVB USB and >> USB-serial driver (usb_set_intfdata). I asked that earlier, see: >> http://www.mail-archive.com/linux-media@vger.kernel.org/msg36027.html > > Yes, and I'll have to give you the same answer as then. > > But, Greg, Antti makes a very valid point here. The generic code assumes that > it owns intfdata, that is you cannot use it as is for access to anything that lacks > its own interface. But this is not a fatal flaw. We can alter the generic code to use > an accessor function the driver can provide and make it default to get/set_intfdata > > What do you think? Oliver, I looked your old thread reply but I didn't catch how you meant it to happen. Could you give some small example? regards Antti -- http://palosaari.fi/