From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/4] v4l: add support for selection api
Date: Wed, 12 Oct 2011 17:08:20 +0200 [thread overview]
Message-ID: <4E95AD64.2020702@samsung.com> (raw)
In-Reply-To: <20111012114828.GE10001@valkosipuli.localdomain>
On 10/12/2011 01:48 PM, Sakari Ailus wrote:
> Hi Tomasz,
>
> On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote:
> ...
>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
>> index fca24cc..b7471fe 100644
>> --- a/include/linux/videodev2.h
>> +++ b/include/linux/videodev2.h
>> @@ -738,6 +738,48 @@ struct v4l2_crop {
>> struct v4l2_rect c;
>> };
>>
>> +/* Hints for adjustments of selection rectangle */
>> +#define V4L2_SEL_SIZE_GE 0x00000001
>> +#define V4L2_SEL_SIZE_LE 0x00000002
>
> A minor comment. If the patches have not been pulled yet, how about adding
> FLAG_ to the flag names? I.e. V4L2_SEL_FLAG_SIZE_GE and
> V4L2_SEL_FLAG_SIZE_LE.
Hi Sakari,
The idea is good. I preferred to avoid using long names if possible.
I agree that using _FLAGS_ produce more informative name.
I'll fix it in the new version of selection API.
Regards,
Tomasz Stanislawski
>
> Kind regards,
>
next prev parent reply other threads:[~2011-10-12 15:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 12:28 [PATCHv5 0/4] v4l: extended crop/compose api Tomasz Stanislawski
2011-08-31 12:28 ` [PATCH 1/4] v4l: add support for selection api Tomasz Stanislawski
2011-09-05 10:25 ` Sakari Ailus
2011-09-05 12:52 ` Laurent Pinchart
2011-09-05 12:55 ` Sakari Ailus
2011-09-23 8:33 ` Laurent Pinchart
2011-09-27 8:28 ` Hans Verkuil
2011-09-29 13:41 ` Tomasz Stanislawski
2011-10-12 11:48 ` Sakari Ailus
2011-10-12 15:08 ` Tomasz Stanislawski [this message]
2011-10-12 16:31 ` Sakari Ailus
2011-10-14 17:19 ` Sakari Ailus
2011-10-17 13:31 ` Tomasz Stanislawski
2011-10-17 16:54 ` Sakari Ailus
2011-08-31 12:28 ` [PATCH 2/4] v4l: add documentation for selection API Tomasz Stanislawski
2011-09-22 22:41 ` Laurent Pinchart
2011-09-23 12:36 ` Tomasz Stanislawski
2011-09-23 13:13 ` Laurent Pinchart
2011-09-23 15:22 ` Tomasz Stanislawski
2011-09-27 11:17 ` Laurent Pinchart
2011-09-27 14:17 ` Tomasz Stanislawski
2011-09-27 15:32 ` Kamil Debski
2011-09-27 9:20 ` Hans Verkuil
2011-09-27 11:11 ` Laurent Pinchart
2011-09-27 11:27 ` Hans Verkuil
2011-09-27 13:36 ` Tomasz Stanislawski
2011-09-27 13:52 ` Hans Verkuil
2011-08-31 12:28 ` [PATCH 3/4] v4l: emulate old crop API using extended crop/compose API Tomasz Stanislawski
2011-08-31 12:28 ` [PATCH 4/4] v4l: s5p-tv: mixer: add support for selection API Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E95AD64.2020702@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox