public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Boris Todorov <boris.st.todorov@gmail.com>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: omap3isp: BT.656 support
Date: Tue, 18 Oct 2011 09:24:19 -0600	[thread overview]
Message-ID: <4E9D9A23.8060604@mlbassoc.com> (raw)
In-Reply-To: <CAFYgh7ybJYX0ec9avYrMf+cCWnp_AU3WivZkROCDLi-6p2WB_A@mail.gmail.com>

On 2011-10-18 09:10, Boris Todorov wrote:
> On Tue, Oct 18, 2011 at 5:49 PM, Gary Thomas<gary@mlbassoc.com>  wrote:
>> On 2011-10-18 08:28, Boris Todorov wrote:
>>>
>>> I'm using different board.
>>
>> What board?  I would think the architecture of the OMAP3 ISP would
>> not change, based on the board?
>
> It's a custom board with omap3630. ISP is not changed.
> When I disable OMAP2_VOUT from defconfig "CCD output" is /dev/video2.

I see, I have that option turned off.

> But result is the same - yavta sleeps at VIDIOC_DQBUF ioctl

How are you configuring the TVP5150?  In particular these settings at boot time:

static struct isp_v4l2_subdevs_group my_camera_subdevs[] = {
	{
		.subdevs = tvp5150_camera_subdevs,
		.interface = ISP_INTERFACE_PARALLEL,
		.bus = {
				.parallel = {
					.data_lane_shift = 0,
					.clk_pol = 1,
                                         .bt656 = 1,
                                         .fldmode = 1,
				}
		},
	},
	{ },
};

This is how you tell the ISP to run in BT656 mode.  Without it, it will run
using the HS/VS/FID signals (and also in my experience does not work properly)

>>
>>> According "media-ctl -p":
>>>
>>> - entity 5: OMAP3 ISP CCDC (3 pads, 9 links)
>>>              type V4L2 subdev subtype Unknown
>>>              device node name /dev/v4l-subdev2
>>>          pad0: Input [UYVY2X8 720x525]
>>>                  <- 'OMAP3 ISP CCP2':pad1 []
>>>                  <- 'OMAP3 ISP CSI2a':pad1 []
>>>                  <- 'tvp5150 3-005c':pad0 [ACTIVE]
>>>          pad1: Output [UYVY2X8 720x525]
>>>                  ->    'OMAP3 ISP CCDC output':pad0 [ACTIVE]
>>>                  ->    'OMAP3 ISP resizer':pad0 []
>>>          pad2: Output [UYVY2X8 720x524]
>>>                  ->    'OMAP3 ISP preview':pad0 []
>>>                  ->    'OMAP3 ISP AEWB':pad0 [IMMUTABLE,ACTIVE]
>>>                  ->    'OMAP3 ISP AF':pad0 [IMMUTABLE,ACTIVE]
>>>                  ->    'OMAP3 ISP histogram':pad0 [IMMUTABLE,ACTIVE]
>>>
>>> - entity 6: OMAP3 ISP CCDC output (1 pad, 1 link)
>>>              type Node subtype V4L
>>>              device node name /dev/video4
>>>          pad0: Input
>>>                  <- 'OMAP3 ISP CCDC':pad1 [ACTIVE]
>>>
>>>
>>> Should be /dev/video4...
>>
>> Could you send your pipeline setup and full output of 'media-ctl -p'?
>
> Pipeline setup is:
>
> $ media-ctl -v -r -l '"tvp5150 3-005c":0->"OMAP3 ISP CCDC":0[1],
> "OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> $ media-ctl -v --set-format '"tvp5150 3-005c":0 [UYVY2X8 720x525]'
> $ media-ctl -v --set-format '"OMAP3 ISP CCDC":0 [UYVY2X8 720x525]'
> $ media-ctl -v --set-format '"OMAP3 ISP CCDC":1 [UYVY2X8 720x525]'
>
> media-ctl output (with /dev/video4):
>
> $ media-ctl -p
> Opening media device /dev/media0
> Enumerating entities
> Found 16 entities
> Enumerating pads and links
> Device topology
> - entity 1: OMAP3 ISP CCP2 (2 pads, 2 links)
>              type V4L2 subdev subtype Unknown
>              device node name /dev/v4l-subdev0
>          pad0: Input [SGRBG10 4096x4096]
>                  <- 'OMAP3 ISP CCP2 input':pad0 []
>          pad1: Output [SGRBG10 4096x4096]
>                  ->  'OMAP3 ISP CCDC':pad0 []
>
> - entity 2: OMAP3 ISP CCP2 input (1 pad, 1 link)
>              type Node subtype V4L
>              device node name /dev/video0
>          pad0: Output
>                  ->  'OMAP3 ISP CCP2':pad0 []
>
> - entity 3: OMAP3 ISP CSI2a (2 pads, 2 links)
>              type V4L2 subdev subtype Unknown
>              device node name /dev/v4l-subdev1
>          pad0: Input [SGRBG10 4096x4096]
>          pad1: Output [SGRBG10 4096x4096]
>                  ->  'OMAP3 ISP CSI2a output':pad0 []
>                  ->  'OMAP3 ISP CCDC':pad0 []
>
> - entity 4: OMAP3 ISP CSI2a output (1 pad, 1 link)
>              type Node subtype V4L
>              device node name /dev/video3
>          pad0: Input
>                  <- 'OMAP3 ISP CSI2a':pad1 []
>
> - entity 5: OMAP3 ISP CCDC (3 pads, 9 links)
>              type V4L2 subdev subtype Unknown
>              device node name /dev/v4l-subdev2
>          pad0: Input [UYVY2X8 720x525]
>                  <- 'OMAP3 ISP CCP2':pad1 []
>                  <- 'OMAP3 ISP CSI2a':pad1 []
>                  <- 'tvp5150 3-005c':pad0 [ACTIVE]
>          pad1: Output [UYVY2X8 720x525]
>                  ->  'OMAP3 ISP CCDC output':pad0 [ACTIVE]
>                  ->  'OMAP3 ISP resizer':pad0 []
>          pad2: Output [UYVY2X8 720x524]
>                  ->  'OMAP3 ISP preview':pad0 []
>                  ->  'OMAP3 ISP AEWB':pad0 [IMMUTABLE,ACTIVE]
>                  ->  'OMAP3 ISP AF':pad0 [IMMUTABLE,ACTIVE]
>                  ->  'OMAP3 ISP histogram':pad0 [IMMUTABLE,ACTIVE]
>
> - entity 6: OMAP3 ISP CCDC output (1 pad, 1 link)
>              type Node subtype V4L
>              device node name /dev/video4
>          pad0: Input
>                  <- 'OMAP3 ISP CCDC':pad1 [ACTIVE]
>
> - entity 7: OMAP3 ISP preview (2 pads, 4 links)
>              type V4L2 subdev subtype Unknown
>              device node name /dev/v4l-subdev3
>          pad0: Input [SGRBG10 4096x4096]
>                  <- 'OMAP3 ISP CCDC':pad2 []
>                  <- 'OMAP3 ISP preview input':pad0 []
>          pad1: Output [YUYV 4082x4088]
>                  ->  'OMAP3 ISP preview output':pad0 []
>                  ->  'OMAP3 ISP resizer':pad0 []
>
> - entity 8: OMAP3 ISP preview input (1 pad, 1 link)
>              type Node subtype V4L
>              device node name /dev/video5
>          pad0: Output
>                  ->  'OMAP3 ISP preview':pad0 []
>
> - entity 9: OMAP3 ISP preview output (1 pad, 1 link)
>              type Node subtype V4L
>              device node name /dev/video6
>          pad0: Input
>                  <- 'OMAP3 ISP preview':pad1 []
>
> - entity 10: OMAP3 ISP resizer (2 pads, 4 links)
>               type V4L2 subdev subtype Unknown
>               device node name /dev/v4l-subdev4
>          pad0: Input [YUYV 4095x4095 (4,6)/4086x4082]
>                  <- 'OMAP3 ISP CCDC':pad1 []
>                  <- 'OMAP3 ISP preview':pad1 []
>                  <- 'OMAP3 ISP resizer input':pad0 []
>          pad1: Output [YUYV 4096x4095]
>                  ->  'OMAP3 ISP resizer output':pad0 []
>
> - entity 11: OMAP3 ISP resizer input (1 pad, 1 link)
>               type Node subtype V4L
>               device node name /dev/video7
>          pad0: Output
>                  ->  'OMAP3 ISP resizer':pad0 []
>
> - entity 12: OMAP3 ISP resizer output (1 pad, 1 link)
>               type Node subtype V4L
>               device node name /dev/video8
>          pad0: Input
>                  <- 'OMAP3 ISP resizer':pad1 []
>
> - entity 13: OMAP3 ISP AEWB (1 pad, 1 link)
>               type V4L2 subdev subtype Unknown
>               device node name /dev/v4l-subdev5
>          pad0: Input
>                  <- 'OMAP3 ISP CCDC':pad2 [IMMUTABLE,ACTIVE]
>
> - entity 14: OMAP3 ISP AF (1 pad, 1 link)
>               type V4L2 subdev subtype Unknown
>               device node name /dev/v4l-subdev6
>          pad0: Input
>                  <- 'OMAP3 ISP CCDC':pad2 [IMMUTABLE,ACTIVE]
>
> - entity 15: OMAP3 ISP histogram (1 pad, 1 link)
>               type V4L2 subdev subtype Unknown
>               device node name /dev/v4l-subdev7
>          pad0: Input
>                  <- 'OMAP3 ISP CCDC':pad2 [IMMUTABLE,ACTIVE]
>
> - entity 16: tvp5150 3-005c (1 pad, 1 link)
>               type V4L2 subdev subtype Unknown
>               device node name /dev/v4l-subdev8
>          pad0: Output [UYVY2X8 720x525]
>                  ->  'OMAP3 ISP CCDC':pad0 [ACTIVE]
>
>>
>>>
>>>
>>> On Tue, Oct 18, 2011 at 5:07 PM, Gary Thomas<gary@mlbassoc.com>    wrote:
>>>>
>>>> On 2011-10-18 07:33, Boris Todorov wrote:
>>>>>
>>>>> Hi
>>>>>
>>>>> I'm trying to run OMAP + TVP5151 in BT656 mode.
>>>>>
>>>>> I'm using omap3isp-omap3isp-yuv (git.linuxtv.org/pinchartl/media.git).
>>>>> Plus the following patches:
>>>>>
>>>>> TVP5151:
>>>>>
>>>>>
>>>>> https://github.com/ebutera/meta-igep/tree/testing-v2/recipes-kernel/linux/linux-3.0+3.1rc/tvp5150
>>>>>
>>>>> The latest RFC patches for BT656 support:
>>>>>
>>>>> Enrico Butera (2):
>>>>>    omap3isp: ispvideo: export isp_video_mbus_to_pix
>>>>>    omap3isp: ispccdc: configure CCDC registers and add BT656 support
>>>>>
>>>>> Javier Martinez Canillas (1):
>>>>>    omap3isp: ccdc: Add interlaced field mode to platform data
>>>>>
>>>>>
>>>>> I'm able to configure with media-ctl:
>>>>>
>>>>> media-ctl -v -r -l '"tvp5150 3-005c":0->"OMAP3 ISP CCDC":0[1], "OMAP3
>>>>> ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
>>>>> media-ctl -v --set-format '"tvp5150 3-005c":0 [UYVY2X8 720x525]'
>>>>> media-ctl -v --set-format '"OMAP3 ISP CCDC":0 [UYVY2X8 720x525]'
>>>>> media-ctl -v --set-format '"OMAP3 ISP CCDC":1 [UYVY2X8 720x525]'
>>>>>
>>>>> But
>>>>> ./yavta -f UYVY -s 720x525 -n 4 --capture=4 -F /dev/video4
>>>>>
>>>>> sleeps after
>>>>> ...
>>>>> Buffer 1 mapped at address 0x4021d000.
>>>>> length: 756000 offset: 1515520
>>>>> Buffer 2 mapped at address 0x402d6000.
>>>>> length: 756000 offset: 2273280
>>>>> Buffer 3 mapped at address 0x4038f000.
>>>>>
>>>>> Anyone with the same issue??? This happens with every other v4l test app
>>>>> I
>>>>> used.
>>>>> I can see data from TVP5151 but there are no interrupts in ISP.
>>>>
>>>> Why are you using /dev/video4?  The CCDC output is on /dev/video2
>>>>
>>>> --
>>>> ------------------------------------------------------------
>>>> Gary Thomas                 |  Consulting for the
>>>> MLB Associates              |    Embedded world
>>>> ------------------------------------------------------------
>>>>
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas                 |  Consulting for the
>> MLB Associates              |    Embedded world
>> ------------------------------------------------------------
>>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

  reply	other threads:[~2011-10-18 15:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18 13:33 omap3isp: BT.656 support Boris Todorov
2011-10-18 14:07 ` Gary Thomas
2011-10-18 14:28   ` Boris Todorov
2011-10-18 14:49     ` Gary Thomas
2011-10-18 15:10       ` Boris Todorov
2011-10-18 15:24         ` Gary Thomas [this message]
2011-10-18 15:53           ` Boris Todorov
2011-10-18 16:04             ` Gary Thomas
2011-10-18 16:14               ` Boris Todorov
2011-10-18 16:24                 ` Gary Thomas
2011-10-18 16:31 ` Enrico
2011-10-19  7:01   ` Boris Todorov
2011-10-19  8:28     ` Enrico
2011-10-19  9:03       ` Boris Todorov
2011-10-19 12:40         ` Enrico
2011-10-19 13:06           ` Boris Todorov
2011-10-19 15:56             ` Boris Todorov
2011-10-19 16:26 ` Stefan Herbrechtsmeier
     [not found]   ` <CAFYgh7xxCM0=hiU9+bFS+qA447wC4+OkCRxv1eonYMgTH7oeEw@mail.gmail.com>
2011-10-20  9:03     ` Stefan Herbrechtsmeier
2011-10-20 12:14       ` Boris Todorov
2011-10-20 14:36         ` Stefan Herbrechtsmeier
2011-10-23 19:15           ` Boris Todorov
2011-10-24  9:47             ` Gary Thomas
2011-10-24 10:33               ` Boris Todorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9D9A23.8060604@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=boris.st.todorov@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox