From: Hans de Goede <hdegoede@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: Various ctrl and event frame work patches (version 2)
Date: Tue, 01 Nov 2011 10:18:24 +0100 [thread overview]
Message-ID: <4EAFB960.8040706@redhat.com> (raw)
In-Reply-To: <201110311717.32581.hverkuil@xs4all.nl>
Hi,
On 10/31/2011 05:17 PM, Hans Verkuil wrote:
> Hi Hans!
>
> On Monday, October 31, 2011 16:16:43 Hans de Goede wrote:
>> Hi All,
>>
>> This patch set obsoletes my previous "add v4l2_subscribed_event_ops" set,
>> while working on adding support for ctrl-events to the uvc driver I found
>> a few bugs in the event code, which this patchset fixes.
>
> Did you see my comments to patches 3/6, 4/6 and 5/6 in version 1?
> Those need to be addressed before I can ack them.
No I'm afraid I somehow completely missed those, I see them in the mailing
list archive. I'll reply to them by copy pasting from the archive,
so if my next replies look a bit out of place wrt their place in
threaded mail readers, that is why.
After that I'll respin the patchset addressing the issues you've pointed out.
Regards,
Hans
prev parent reply other threads:[~2011-11-01 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 15:16 Various ctrl and event frame work patches (version 2) Hans de Goede
2011-10-31 15:16 ` [PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls Hans de Goede
2011-10-31 15:16 ` [PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL Hans de Goede
2011-10-31 15:16 ` [PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing Hans de Goede
2011-11-02 10:00 ` Sakari Ailus
2011-10-31 15:16 ` [PATCH 4/6] v4l2-event: Don't set sev->fh to NULL on unsubcribe Hans de Goede
2011-10-31 15:16 ` [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops Hans de Goede
2011-10-31 15:16 ` [PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops Hans de Goede
2011-10-31 16:17 ` Various ctrl and event frame work patches (version 2) Hans Verkuil
2011-11-01 9:18 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAFB960.8040706@redhat.com \
--to=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox