Re: [PATCH] v4l: Add VIDIOC_LOG_STATUS support for sub-device nodes

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

Hi Laurent,

On 11/04/2011 11:43 AM, Laurent Pinchart wrote:
> On Wednesday 02 November 2011 17:15:57 Sylwester Nawrocki wrote:
...
>> diff --git a/drivers/media/video/v4l2-subdev.c
>> b/drivers/media/video/v4l2-subdev.c index 179e20e..4fe1e7a 100644
>> --- a/drivers/media/video/v4l2-subdev.c
>> +++ b/drivers/media/video/v4l2-subdev.c
>> @@ -192,6 +192,9 @@ static long subdev_do_ioctl(struct file *file, unsigned
>> int cmd, void *arg) return v4l2_subdev_call(sd, core, s_register, p);
>>  	}
>>  #endif
> 
> I would have put a blank line here, but that's probably just me :-)

Doesn't sound like a significant improvement, but indeed looks better;)
I'll update this when adding to a pull request.

> 
>> +	case VIDIOC_LOG_STATUS:
>> +		return v4l2_subdev_call(sd, core, log_status);
>> +
>>  #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>>  	case VIDIOC_SUBDEV_G_FMT: {
>>  		struct v4l2_subdev_format *format = arg;

--
Thanks,
Sylwester