[PATCH] v4l: Add VIDIOC_LOG_STATUS support for sub-device nodes

[PATCH] v4l: Add VIDIOC_LOG_STATUS support for sub-device nodes

[Sylwester Nawrocki]

The VIDIOC_LOG_STATUS ioctl allows to dump current status of a driver
to the kernel log. Currently this ioctl is only available at video 
device nodes and the subdevs rely on the host driver to expose their 
core.log_status operation to user space.

This patch adds VIDIOC_LOG_STATUS support at the sub-device nodes,
for standalone subdevs that expose their own /dev entry.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/media/video/v4l2-subdev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/v4l2-subdev.c b/drivers/media/video/v4l2-subdev.c
index 179e20e..4fe1e7a 100644
--- a/drivers/media/video/v4l2-subdev.c
+++ b/drivers/media/video/v4l2-subdev.c
@@ -192,6 +192,9 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg)
 		return v4l2_subdev_call(sd, core, s_register, p);
 	}
 #endif
+	case VIDIOC_LOG_STATUS:
+		return v4l2_subdev_call(sd, core, log_status);
+
 #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
 	case VIDIOC_SUBDEV_G_FMT: {
 		struct v4l2_subdev_format *format = arg;
-- 
1.7.7.1

Re: [PATCH] v4l: Add VIDIOC_LOG_STATUS support for sub-device nodes

[Laurent Pinchart]

Hi Sylwester,

Thanks for the patch.

On Wednesday 02 November 2011 17:15:57 Sylwester Nawrocki wrote:
> The VIDIOC_LOG_STATUS ioctl allows to dump current status of a driver
> to the kernel log. Currently this ioctl is only available at video
> device nodes and the subdevs rely on the host driver to expose their
> core.log_status operation to user space.
> 
> This patch adds VIDIOC_LOG_STATUS support at the sub-device nodes,
> for standalone subdevs that expose their own /dev entry.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/video/v4l2-subdev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/v4l2-subdev.c
> b/drivers/media/video/v4l2-subdev.c index 179e20e..4fe1e7a 100644
> --- a/drivers/media/video/v4l2-subdev.c
> +++ b/drivers/media/video/v4l2-subdev.c
> @@ -192,6 +192,9 @@ static long subdev_do_ioctl(struct file *file, unsigned
> int cmd, void *arg) return v4l2_subdev_call(sd, core, s_register, p);
>  	}
>  #endif

I would have put a blank line here, but that's probably just me :-)

> +	case VIDIOC_LOG_STATUS:
> +		return v4l2_subdev_call(sd, core, log_status);
> +
>  #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>  	case VIDIOC_SUBDEV_G_FMT: {
>  		struct v4l2_subdev_format *format = arg;

-- 
Regards,

Laurent Pinchart

Re: [PATCH] v4l: Add VIDIOC_LOG_STATUS support for sub-device nodes

[Sylwester Nawrocki]

Hi Laurent,

On 11/04/2011 11:43 AM, Laurent Pinchart wrote:
> On Wednesday 02 November 2011 17:15:57 Sylwester Nawrocki wrote:
...
>> diff --git a/drivers/media/video/v4l2-subdev.c
>> b/drivers/media/video/v4l2-subdev.c index 179e20e..4fe1e7a 100644
>> --- a/drivers/media/video/v4l2-subdev.c
>> +++ b/drivers/media/video/v4l2-subdev.c
>> @@ -192,6 +192,9 @@ static long subdev_do_ioctl(struct file *file, unsigned
>> int cmd, void *arg) return v4l2_subdev_call(sd, core, s_register, p);
>>  	}
>>  #endif
> 
> I would have put a blank line here, but that's probably just me :-)

Doesn't sound like a significant improvement, but indeed looks better;)
I'll update this when adding to a pull request.

> 
>> +	case VIDIOC_LOG_STATUS:
>> +		return v4l2_subdev_call(sd, core, log_status);
>> +
>>  #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>>  	case VIDIOC_SUBDEV_G_FMT: {
>>  		struct v4l2_subdev_format *format = arg;

--
Thanks,
Sylwester