From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Pawel Osciak <pawel@osciak.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Angela Wan <angela.j.wan@gmail.com>,
linux-media@vger.kernel.org, leiwen@marvell.com,
ytang5@marvell.com, qingx@marvell.com, jwan@marvell.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] media: vb2: reset queued list on REQBUFS(0) call
Date: Mon, 07 Nov 2011 11:46:05 -0200 [thread overview]
Message-ID: <4EB7E11D.4060709@redhat.com> (raw)
In-Reply-To: <CAMm-=zBt9HufMLpvcDBfD3qS1vL+zwm77APcfVcPQst1zqEyPw@mail.gmail.com>
Em 25-10-2011 06:11, Pawel Osciak escreveu:
> On Tue, Oct 25, 2011 at 00:59, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> Queued list was not reset on REQBUFS(0) call. This caused enqueuing
>> a freed buffer to the driver.
>>
>> Reported-by: Angela Wan <angela.j.wan@gmail.com>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/media/video/videobuf2-core.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/videobuf2-core.c
>> b/drivers/media/video/videobuf2-core.c
>> index 3015e60..5722b81 100644
>> --- a/drivers/media/video/videobuf2-core.c
>> +++ b/drivers/media/video/videobuf2-core.c
>> @@ -254,6 +254,7 @@ static void __vb2_queue_free(struct vb2_queue *q)
>>
>> q->num_buffers = 0;
>> q->memory = 0;
>> + INIT_LIST_HEAD(&q->queued_list);
>> }
>>
>> /**
>> --
>> 1.7.1
>>
>>
>>
>
> Acked-by: Pawel Osciak <pawel@osciak.com>
>
This patch doesn't apply anymore. Is it still needed? If so, please rebase.
Thanks!
Mauro
next prev parent reply other threads:[~2011-11-07 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 3:25 Reqbufs(0) need to release queued_list Angela Wan
2011-10-24 19:39 ` Guennadi Liakhovetski
2011-10-24 20:55 ` Marek Szyprowski
2011-10-25 7:59 ` [PATCH] media: vb2: reset queued list on REQBUFS(0) call Marek Szyprowski
2011-10-25 8:07 ` Angela Wan
2011-10-25 8:14 ` Pawel Osciak
2011-10-25 8:11 ` Pawel Osciak
2011-11-07 13:46 ` Mauro Carvalho Chehab [this message]
2011-11-07 14:14 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7E11D.4060709@redhat.com \
--to=mchehab@redhat.com \
--cc=angela.j.wan@gmail.com \
--cc=jwan@marvell.com \
--cc=kyungmin.park@samsung.com \
--cc=leiwen@marvell.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=qingx@marvell.com \
--cc=ytang5@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox