From: Sylwester Nawrocki <snjw23@gmail.com>
To: gennarone@gmail.com
Cc: linux-media <linux-media@vger.kernel.org>,
Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver
Date: Mon, 07 Nov 2011 20:57:51 +0100 [thread overview]
Message-ID: <4EB8383F.2000201@gmail.com> (raw)
In-Reply-To: <4EB802A0.7030600@gmail.com>
Hi Gianluca,
On 11/07/2011 05:09 PM, Gianluca Gennari wrote:
> Hi Sylwestwer,
> I was about to test the new driver when I discovered that my as102
> device is not included in the list of supported devices:
>
> /* Super Digi KEY */
> #define AS102_SUPER_DIGI_NAME "Super Digi KEY"
> #define SUPER_DIGI_USB_VID 0x2137
> #define SUPER_DIGI_USB_PID 0x0001
>
> It's a "Digital key" offered by Sky Italia to its customers to watch
> terrestrial programs with the Sky satellite decoders.
I'm not sure if your device needs some special handling, but it might work
if you repeat steps as in this patch:
http://git.linuxtv.org/media_tree.git/commitdiff/5f9745b2c942b2ab220831b2c51a18c3f1374249
Have you tried it already ?
Possibly something like this is enough (only compile tested):
diff --git a/drivers/staging/media/as102/as102_usb_drv.c b/drivers/staging/media/as102/as102_usb_drv.c
index 9faab5b..9edb366 100644
--- a/drivers/staging/media/as102/as102_usb_drv.c
+++ b/drivers/staging/media/as102/as102_usb_drv.c
@@ -42,6 +42,7 @@ static struct usb_device_id as102_usb_id_table[] = {
{ USB_DEVICE(PCTV_74E_USB_VID, PCTV_74E_USB_PID) },
{ USB_DEVICE(ELGATO_EYETV_DTT_USB_VID, ELGATO_EYETV_DTT_USB_PID) },
{ USB_DEVICE(NBOX_DVBT_DONGLE_USB_VID, NBOX_DVBT_DONGLE_USB_PID) },
+ { USB_DEVICE(SUPER_DIGI_USB_VID, SUPER_DIGI_USB_PID) },
{ } /* Terminating entry */
};
@@ -52,6 +53,7 @@ static const char * const as102_device_names[] = {
AS102_PCTV_74E,
AS102_ELGATO_EYETV_DTT_NAME,
AS102_NBOX_DVBT_DONGLE_NAME,
+ AS102_SUPER_DIGI_NAME,
NULL /* Terminating entry */
};
diff --git a/drivers/staging/media/as102/as102_usb_drv.h b/drivers/staging/media/as102/as102_usb_drv.h
index 35925b7..6f95af2 100644
--- a/drivers/staging/media/as102/as102_usb_drv.h
+++ b/drivers/staging/media/as102/as102_usb_drv.h
@@ -47,6 +47,11 @@
#define NBOX_DVBT_DONGLE_USB_VID 0x0b89
#define NBOX_DVBT_DONGLE_USB_PID 0x0007
+/* Super Digi KEY */
+#define AS102_SUPER_DIGI_NAME "Super Digi KEY"
+#define SUPER_DIGI_USB_VID 0x2137
+#define SUPER_DIGI_USB_PID 0x0001
+
My knowledge about this driver is rather limited, in case of any issues I
guess it's best to ask Devin directly.
--
Regards,
Sylwester
next prev parent reply other threads:[~2011-11-07 19:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 20:31 [PATCH 00/13] Remaining coding style clean up of AS102 driver Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 01/13] staging: as102: Remove comment tags for editors configuration Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 02/13] staging: as102: Remove unnecessary typedefs Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 03/13] staging: as102: Remove leftovers of the SPI bus driver Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 04/13] staging: as102: Make the driver select CONFIG_FW_LOADER Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 05/13] staging: as102: Replace pragma(pack) with attribute __packed Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 06/13] staging: as102: Fix the dvb device registration error path Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 07/13] staging: as102: Whitespace and indentation cleanup Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 08/13] staging: as102: Replace printk(KERN_<LEVEL> witk pr_<level> Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 09/13] staging: as102: Remove linkage specifiers for C++ Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 10/13] staging: as102: Use linux/uaccess.h instead of asm/uaccess.h Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 11/13] staging: as102: Move variable declarations to the header Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 12/13] staging: as102: Define device name string pointers constant Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 13/13] staging: as102: Eliminate as10x_handle_t alias Sylwester Nawrocki
[not found] ` <4EB7F709.2050503@gmail.com>
2011-11-07 19:55 ` [PATCH 00/13] Remaining coding style clean up of AS102 driver Sylwester Nawrocki
[not found] ` <4EB802A0.7030600@gmail.com>
2011-11-07 19:57 ` Sylwester Nawrocki [this message]
2011-11-07 20:06 ` Devin Heitmueller
2011-11-08 13:36 ` Mauro Carvalho Chehab
2011-11-08 22:40 ` Sylwester Nawrocki
2011-11-08 23:16 ` [PATCH] staging: as102: Add missing function argument Sylwester Nawrocki
2011-11-17 16:35 ` [PATCH] staging: as102: Add support for Sky Italia Digital Key based on the same chip Gianluca Gennari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB8383F.2000201@gmail.com \
--to=snjw23@gmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=gennarone@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox