From: Sylwester Nawrocki <snjw23@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org,
Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver
Date: Tue, 08 Nov 2011 23:40:07 +0100 [thread overview]
Message-ID: <4EB9AFC7.6000803@gmail.com> (raw)
In-Reply-To: <4EB9304C.5020305@redhat.com>
On 11/08/2011 02:36 PM, Mauro Carvalho Chehab wrote:
> I got a few warnings here, after applying the patch series:
>
> drivers/staging/media/as102/as102_drv.c: In function ‘as102_dvb_register’:
> drivers/staging/media/as102/as102_drv.c:223:3: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
> include/linux/device.h:812:12: note: expected ‘const struct device *’ but argument is of type ‘char *’
> drivers/staging/media/as102/as102_drv.c:223:3: warning: too many arguments for format [-Wformat-extra-args]
>
> please check.
Yes, there was an error in patch 06/13, this has been pointed out yesterday.
I intended to resend the patch, but since you have already pulled the whole series.. :),
I'll post an additional patch to fix the problem.
--
Cheers,
Sylwester
next prev parent reply other threads:[~2011-11-08 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 20:31 [PATCH 00/13] Remaining coding style clean up of AS102 driver Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 01/13] staging: as102: Remove comment tags for editors configuration Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 02/13] staging: as102: Remove unnecessary typedefs Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 03/13] staging: as102: Remove leftovers of the SPI bus driver Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 04/13] staging: as102: Make the driver select CONFIG_FW_LOADER Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 05/13] staging: as102: Replace pragma(pack) with attribute __packed Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 06/13] staging: as102: Fix the dvb device registration error path Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 07/13] staging: as102: Whitespace and indentation cleanup Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 08/13] staging: as102: Replace printk(KERN_<LEVEL> witk pr_<level> Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 09/13] staging: as102: Remove linkage specifiers for C++ Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 10/13] staging: as102: Use linux/uaccess.h instead of asm/uaccess.h Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 11/13] staging: as102: Move variable declarations to the header Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 12/13] staging: as102: Define device name string pointers constant Sylwester Nawrocki
2011-11-06 20:31 ` [PATCH 13/13] staging: as102: Eliminate as10x_handle_t alias Sylwester Nawrocki
[not found] ` <4EB7F709.2050503@gmail.com>
2011-11-07 19:55 ` [PATCH 00/13] Remaining coding style clean up of AS102 driver Sylwester Nawrocki
[not found] ` <4EB802A0.7030600@gmail.com>
2011-11-07 19:57 ` Sylwester Nawrocki
2011-11-07 20:06 ` Devin Heitmueller
2011-11-08 13:36 ` Mauro Carvalho Chehab
2011-11-08 22:40 ` Sylwester Nawrocki [this message]
2011-11-08 23:16 ` [PATCH] staging: as102: Add missing function argument Sylwester Nawrocki
2011-11-17 16:35 ` [PATCH] staging: as102: Add support for Sky Italia Digital Key based on the same chip Gianluca Gennari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9AFC7.6000803@gmail.com \
--to=snjw23@gmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox