public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: linux-media <linux-media@vger.kernel.org>
Cc: Michael Krufky <mkrufky@kernellabs.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: [RFC 1/2] dvb-core: add generic helper function for I2C register
Date: Wed, 09 Nov 2011 01:54:34 +0200	[thread overview]
Message-ID: <4EB9C13A.2060707@iki.fi> (raw)

Function that splits and sends most typical I2C register write.

Signed-off-by: Antti Palosaari <crope@iki.fi>
---
  drivers/media/dvb/dvb-core/Makefile      |    2 +-
  drivers/media/dvb/dvb-core/dvb_generic.c |   48 
++++++++++++++++++++++++++++++
  drivers/media/dvb/dvb-core/dvb_generic.h |   21 +++++++++++++
  3 files changed, 70 insertions(+), 1 deletions(-)
  create mode 100644 drivers/media/dvb/dvb-core/dvb_generic.c
  create mode 100644 drivers/media/dvb/dvb-core/dvb_generic.h

diff --git a/drivers/media/dvb/dvb-core/Makefile 
b/drivers/media/dvb/dvb-core/Makefile
index 8f22bcd..230584a 100644
--- a/drivers/media/dvb/dvb-core/Makefile
+++ b/drivers/media/dvb/dvb-core/Makefile
@@ -6,6 +6,6 @@ dvb-net-$(CONFIG_DVB_NET) := dvb_net.o

  dvb-core-objs := dvbdev.o dmxdev.o dvb_demux.o dvb_filter.o 	\
  		 dvb_ca_en50221.o dvb_frontend.o 		\
-		 $(dvb-net-y) dvb_ringbuffer.o dvb_math.o
+		 $(dvb-net-y) dvb_ringbuffer.o dvb_math.o dvb_generic.o

  obj-$(CONFIG_DVB_CORE) += dvb-core.o
diff --git a/drivers/media/dvb/dvb-core/dvb_generic.c 
b/drivers/media/dvb/dvb-core/dvb_generic.c
new file mode 100644
index 0000000..002bd24
--- /dev/null
+++ b/drivers/media/dvb/dvb-core/dvb_generic.c
@@ -0,0 +1,48 @@
+#include <linux/i2c.h>
+#include "dvb_generic.h"
+
+/* write multiple registers */
+int dvb_wr_regs(struct dvb_i2c_cfg *i2c_cfg, u8 reg, u8 *val, int len_tot)
+{
+#define REG_ADDR_LEN 1
+#define REG_VAL_LEN 1
+	int ret, len_cur, len_rem, len_max;
+	u8 buf[i2c_cfg->max_wr];
+	struct i2c_msg msg[1] = {
+		{
+			.addr = i2c_cfg->addr,
+			.flags = 0,
+			.buf = buf,
+		}
+	};
+
+	len_max = i2c_cfg->max_wr - REG_ADDR_LEN;
+	for (len_rem = len_tot; len_rem > 0; len_rem -= len_max) {
+		len_cur = len_rem;
+		if (len_cur > len_max)
+			len_cur = len_max;
+
+		msg[0].len = len_cur + REG_ADDR_LEN;
+		buf[0] = reg;
+		memcpy(&buf[REG_ADDR_LEN], &val[len_tot - len_rem], len_cur);
+
+		ret = i2c_transfer(i2c_cfg->adapter, msg, 1);
+		if (ret != 1) {
+			warn("i2c wr failed=%d reg=%02x len=%d",
+				ret, reg, len_cur);
+			return -EREMOTEIO;
+		}
+		reg += len_cur;
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(dvb_wr_regs);
+
+/* write single register */
+int dvb_wr_reg(struct dvb_i2c_cfg *i2c_cfg, u8 reg, u8 val)
+{
+	return dvb_wr_regs(i2c_cfg, reg, &val, 1);
+}
+EXPORT_SYMBOL(dvb_wr_reg);
+
diff --git a/drivers/media/dvb/dvb-core/dvb_generic.h 
b/drivers/media/dvb/dvb-core/dvb_generic.h
new file mode 100644
index 0000000..7a140ab
--- /dev/null
+++ b/drivers/media/dvb/dvb-core/dvb_generic.h
@@ -0,0 +1,21 @@
+#ifndef DVB_GENERIC_H
+#define DVB_GENERIC_H
+
+#define DVB_GENERIC_LOG_PREFIX "dvb_generic"
+#define warn(f, arg...) \
+	printk(KERN_WARNING DVB_GENERIC_LOG_PREFIX": " f "\n", ## arg)
+
+struct dvb_i2c_cfg {
+	struct i2c_adapter *adapter;
+	u8 addr;
+	/* TODO: reg_addr_len; as now use one byte */
+	/* TODO: reg_val_len; as now use one byte */
+	u8 max_wr;
+	u8 max_rd;
+};
+
+extern int dvb_wr_regs(struct dvb_i2c_cfg *, u8, u8 *, int);
+extern int dvb_wr_reg(struct dvb_i2c_cfg *, u8, u8);
+
+#endif
+
-- 
1.7.4.4

             reply	other threads:[~2011-11-08 23:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 23:54 Antti Palosaari [this message]
2011-11-09  4:48 ` [RFC 1/2] dvb-core: add generic helper function for I2C register Michael Krufky
2011-11-09  9:56 ` Mauro Carvalho Chehab
2011-11-09 10:37   ` Jean Delvare
2011-11-09 11:00     ` Antti Palosaari
2011-11-09 12:02     ` Mauro Carvalho Chehab
2011-11-10  8:26       ` Jean Delvare
2011-11-09 15:51     ` Antti Palosaari
2011-11-09 10:41   ` Antti Palosaari
2011-11-09 10:52     ` Jean Delvare
2011-11-09 20:41       ` Malcolm Priestley
2011-11-14 13:52 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB9C13A.2060707@iki.fi \
    --to=crope@iki.fi \
    --cc=khali@linux-fr.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=mkrufky@kernellabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox