From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34407 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476Ab1KKWij (ORCPT ); Fri, 11 Nov 2011 17:38:39 -0500 Message-ID: <4EBDA3D2.6060506@redhat.com> Date: Fri, 11 Nov 2011 20:38:10 -0200 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Manu Abraham CC: Andreas Oberritter , Linux Media Mailing List , Steven Toth Subject: Re: PATCH: Query DVB frontend capabilities References: <4EBBE336.8050501@linuxtv.org> <4EBC402E.20208@redhat.com> <4EBCF4F1.2030606@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 11-11-2011 20:07, Manu Abraham escreveu: > On Fri, Nov 11, 2011 at 3:42 PM, Mauro Carvalho Chehab > wrote: >> Em 11-11-2011 04:26, Manu Abraham escreveu: >>> On Fri, Nov 11, 2011 at 2:50 AM, Mauro Carvalho Chehab >>> wrote: >>>> Em 10-11-2011 13:30, Manu Abraham escreveu: >>> The purpose of the patch is to >>> query DVB delivery system capabilities alone, rather than DVB frontend >>> info/capability. >>> >>> Attached is a revised version 2 of the patch, which addresses the >>> issues that were raised. >> >> It looks good for me. I would just rename it to DTV_SUPPORTED_DELIVERY. >> Please, when submitting upstream, don't forget to increment DVB version and >> add touch at DocBook, in order to not increase the gap between API specs and the >> implementation. > > Ok, thanks for the feedback, will do that. > > The naming issue is trivial. I would like to have a shorter name > rather that SUPPORTED. CAPS would have been ideal, since it refers to > device capability. CAPS is not a good name, as there are those two CAPABILITIES calls there (well, currently not implemented). So, it can lead in to some confusion. DTV_ENUM_DELIVERY could be an alternative for a short name to be used there. > > Regards, > Manu > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html